Skip to content

Conversation

@mxsm
Copy link
Member

@mxsm mxsm commented Jul 23, 2022

Make sure set the target branch to develop

What is the purpose of the change

Fix #4673

Brief changelog

Verifying this change

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@codecov-commenter
Copy link

Codecov Report

Merging #4675 (93e136e) into develop (a3aef17) will decrease coverage by 0.08%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             develop    #4675      +/-   ##
=============================================
- Coverage      44.69%   44.60%   -0.09%     
+ Complexity      7516     7487      -29     
=============================================
  Files            975      975              
  Lines          67378    67378              
  Branches        8892     8892              
=============================================
- Hits           30112    30054      -58     
- Misses         33550    33597      +47     
- Partials        3716     3727      +11     
Impacted Files Coverage Δ
...va/org/apache/rocketmq/store/FlushDiskWatcher.java 81.25% <0.00%> (-9.38%) ⬇️
...q/namesrv/routeinfo/BrokerHousekeepingService.java 72.72% <0.00%> (-9.10%) ⬇️
...a/org/apache/rocketmq/logging/inner/SysLogger.java 28.57% <0.00%> (-5.72%) ⬇️
...ache/rocketmq/common/stats/MomentStatsItemSet.java 39.13% <0.00%> (-4.35%) ⬇️
...java/org/apache/rocketmq/logging/inner/Logger.java 51.67% <0.00%> (-4.31%) ⬇️
...apache/rocketmq/remoting/netty/ResponseFuture.java 77.55% <0.00%> (-4.09%) ⬇️
...rocketmq/remoting/netty/NettyRemotingAbstract.java 49.82% <0.00%> (-3.95%) ⬇️
...lient/impl/consumer/DefaultMQPushConsumerImpl.java 31.64% <0.00%> (-3.77%) ⬇️
...he/rocketmq/client/trace/AsyncTraceDispatcher.java 81.42% <0.00%> (-1.43%) ⬇️
...rg/apache/rocketmq/remoting/netty/NettyLogger.java 14.96% <0.00%> (-1.37%) ⬇️
... and 17 more

Help us with your feedback. Take ten seconds to tell us how you rate us.

@RongtongJin RongtongJin merged commit 16416aa into apache:develop Jul 23, 2022
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.07%) to 48.85% when pulling 93e136e on mxsm:rocketmq-4673 into a3aef17 on apache:develop.

@mxsm mxsm deleted the rocketmq-4673 branch July 24, 2022 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Docs]DLedger quick start document optimize

4 participants