Skip to content

Conversation

@lollipopjin
Copy link
Contributor

Make sure set the target branch to develop

What is the purpose of the change

In proxy model, return acceptMessageTypes for querying topic route.

Brief changelog

In proxy model, return acceptMessageTypes, which is already stored in TopicConfig.

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@codecov-commenter
Copy link

codecov-commenter commented Jul 25, 2022

Codecov Report

Merging #4691 (64a94b9) into develop (3602b45) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@              Coverage Diff              @@
##             develop    #4691      +/-   ##
=============================================
+ Coverage      44.59%   44.61%   +0.01%     
+ Complexity      7522     7519       -3     
=============================================
  Files            977      977              
  Lines          67582    67593      +11     
  Branches        8927     8927              
=============================================
+ Hits           30138    30154      +16     
+ Misses         33726    33718       -8     
- Partials        3718     3721       +3     
Impacted Files Coverage Δ
...g/apache/rocketmq/common/message/MessageConst.java 98.03% <100.00%> (+0.03%) ⬆️
...he/rocketmq/proxy/grpc/v2/route/RouteActivity.java 91.94% <100.00%> (+0.57%) ⬆️
...rg/apache/rocketmq/common/stats/StatsSnapshot.java 84.61% <0.00%> (-15.39%) ⬇️
.../apache/rocketmq/common/stats/MomentStatsItem.java 38.09% <0.00%> (-9.53%) ⬇️
...ache/rocketmq/common/stats/MomentStatsItemSet.java 39.13% <0.00%> (-8.70%) ⬇️
...va/org/apache/rocketmq/common/stats/StatsItem.java 50.00% <0.00%> (-5.00%) ⬇️
...org/apache/rocketmq/common/stats/StatsItemSet.java 41.79% <0.00%> (-2.99%) ⬇️
...ache/rocketmq/broker/client/ConsumerGroupInfo.java 68.46% <0.00%> (-0.91%) ⬇️
...he/rocketmq/client/trace/AsyncTraceDispatcher.java 82.85% <0.00%> (-0.48%) ⬇️
...cketmq/broker/schedule/ScheduleMessageService.java 57.61% <0.00%> (-0.47%) ⬇️
... and 9 more

Help us with your feedback. Take ten seconds to tell us how you rate us.

@coveralls
Copy link

coveralls commented Jul 25, 2022

Coverage Status

Coverage increased (+0.02%) to 48.833% when pulling 64a94b9 on lollipopjin:develop into 3602b45 on apache:develop.

Copy link
Member

@zhouxinyu zhouxinyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

@zhouxinyu zhouxinyu merged commit 326f51e into apache:develop Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants