Skip to content

fix: use handle saved in receiptHandleProcessor to changeInvisibleTime#4724

Merged
zhouxinyu merged 1 commit intoapache:developfrom
xdkxlk:develop
Jul 29, 2022
Merged

fix: use handle saved in receiptHandleProcessor to changeInvisibleTime#4724
zhouxinyu merged 1 commit intoapache:developfrom
xdkxlk:develop

Conversation

@xdkxlk
Copy link
Copy Markdown
Contributor

@xdkxlk xdkxlk commented Jul 29, 2022

…e if not null

Make sure set the target branch to develop

What is the purpose of the change

When handle has been renewed by proxy, should use handle saved in receiptHandleProcessor to changeInvisibleTime

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.04%) to 49.029% when pulling 6eef12b on xdkxlk:develop into c0e3751 on apache:develop.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jul 29, 2022

Codecov Report

Merging #4724 (6eef12b) into develop (c0e3751) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

@@              Coverage Diff              @@
##             develop    #4724      +/-   ##
=============================================
- Coverage      44.82%   44.78%   -0.05%     
+ Complexity      7564     7546      -18     
=============================================
  Files            977      977              
  Lines          67640    67640              
  Branches        8933     8934       +1     
=============================================
- Hits           30321    30290      -31     
- Misses         33581    33610      +29     
- Partials        3738     3740       +2     
Impacted Files Coverage Δ
...c/v2/consumer/ChangeInvisibleDurationActivity.java 100.00% <100.00%> (ø)
...ache/rocketmq/common/stats/MomentStatsItemSet.java 39.13% <0.00%> (-4.35%) ⬇️
...lient/impl/consumer/DefaultMQPushConsumerImpl.java 33.20% <0.00%> (-2.21%) ⬇️
...mq/client/impl/consumer/RebalanceLitePullImpl.java 69.86% <0.00%> (-1.37%) ⬇️
...nt/impl/consumer/ConsumeMessageOrderlyService.java 49.47% <0.00%> (-0.71%) ⬇️
...rocketmq/client/impl/factory/MQClientInstance.java 47.02% <0.00%> (-0.70%) ⬇️
...rocketmq/broker/processor/PopMessageProcessor.java 38.19% <0.00%> (-0.55%) ⬇️
.../org/apache/rocketmq/store/ha/DefaultHAClient.java 61.02% <0.00%> (-0.52%) ⬇️
...pl/consumer/ConsumeMessageConcurrentlyService.java 47.68% <0.00%> (-0.47%) ⬇️
...he/rocketmq/client/impl/consumer/ProcessQueue.java 61.92% <0.00%> (-0.46%) ⬇️
... and 10 more

Help us with your feedback. Take ten seconds to tell us how you rate us.

@zhouxinyu zhouxinyu merged commit 67b49b5 into apache:develop Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants