Skip to content

[ISSUE #4726] Return error when unregisterBroker is failed#4727

Merged
RongtongJin merged 13 commits intoapache:developfrom
Oliverwqcwrw:develop-unregisterbroker-optimization-41
Jul 30, 2022
Merged

[ISSUE #4726] Return error when unregisterBroker is failed#4727
RongtongJin merged 13 commits intoapache:developfrom
Oliverwqcwrw:develop-unregisterbroker-optimization-41

Conversation

@Oliverwqcwrw
Copy link
Copy Markdown
Member

Make sure set the target branch to develop

What is the purpose of the change

Close #4726

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jul 30, 2022

Codecov Report

Merging #4727 (51b8cc4) into develop (67b49b5) will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             develop    #4727   +/-   ##
==========================================
  Coverage      44.81%   44.82%           
+ Complexity      7560     7556    -4     
==========================================
  Files            977      977           
  Lines          67640    67643    +3     
  Branches        8934     8934           
==========================================
+ Hits           30315    30319    +4     
- Misses         33580    33586    +6     
+ Partials        3745     3738    -7     
Impacted Files Coverage Δ
...org/apache/rocketmq/broker/out/BrokerOuterAPI.java 19.21% <0.00%> (-0.05%) ⬇️
...tmq/namesrv/processor/DefaultRequestProcessor.java 61.79% <0.00%> (-0.53%) ⬇️
...e/rocketmq/namesrv/routeinfo/RouteInfoManager.java 65.94% <ø> (-0.06%) ⬇️
...ava/org/apache/rocketmq/filter/util/BitsArray.java 59.82% <0.00%> (-2.57%) ⬇️
...lient/impl/consumer/DefaultMQPushConsumerImpl.java 33.20% <0.00%> (-2.21%) ⬇️
...ache/rocketmq/broker/client/ConsumerGroupInfo.java 68.46% <0.00%> (-0.91%) ⬇️
...client/consumer/store/RemoteBrokerOffsetStore.java 68.14% <0.00%> (-0.89%) ⬇️
.../org/apache/rocketmq/proxy/config/ProxyConfig.java 48.08% <0.00%> (-0.55%) ⬇️
...rocketmq/broker/processor/PopMessageProcessor.java 38.19% <0.00%> (-0.55%) ⬇️
.../org/apache/rocketmq/store/ha/DefaultHAClient.java 61.02% <0.00%> (-0.52%) ⬇️
... and 18 more

Help us with your feedback. Take ten seconds to tell us how you rate us.

@coveralls
Copy link
Copy Markdown

coveralls commented Jul 30, 2022

Coverage Status

Coverage decreased (-0.008%) to 49.066% when pulling 51b8cc4 on Oliverwqcwrw:develop-unregisterbroker-optimization-41 into 67b49b5 on apache:develop.

@HScarb
Copy link
Copy Markdown
Contributor

HScarb commented Jul 30, 2022

Could you squash all commits into one commit?

@RongtongJin RongtongJin merged commit 975c232 into apache:develop Jul 30, 2022
@Oliverwqcwrw
Copy link
Copy Markdown
Member Author

Could you squash all commits into one commit?

Hello, @HScarb
Thanks for your suggestion. I will squash it next time when I submit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UnregisterBroker always success although is failed

5 participants