Skip to content

[ISSUE #4729] Fix ambiguous error log message#4730

Merged
RongtongJin merged 12 commits intoapache:developfrom
Oliverwqcwrw:develop-log-message-42
Jul 30, 2022
Merged

[ISSUE #4729] Fix ambiguous error log message#4730
RongtongJin merged 12 commits intoapache:developfrom
Oliverwqcwrw:develop-log-message-42

Conversation

@Oliverwqcwrw
Copy link
Member

Make sure set the target branch to develop

What is the purpose of the change

Close #4729

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 48.85% when pulling d4a32a3 on Oliverwqcwrw:develop-log-message-42 into 67b49b5 on apache:develop.

@codecov-commenter
Copy link

Codecov Report

Merging #4730 (d4a32a3) into develop (67b49b5) will increase coverage by 0.03%.
The diff coverage is 0.00%.

@@              Coverage Diff              @@
##             develop    #4730      +/-   ##
=============================================
+ Coverage      44.81%   44.85%   +0.03%     
- Complexity      7560     7564       +4     
=============================================
  Files            977      977              
  Lines          67640    67640              
  Branches        8934     8934              
=============================================
+ Hits           30315    30338      +23     
+ Misses         33580    33563      -17     
+ Partials        3745     3739       -6     
Impacted Files Coverage Δ
...e/rocketmq/namesrv/routeinfo/RouteInfoManager.java 65.99% <0.00%> (ø)
...he/rocketmq/broker/processor/PopReviveService.java 24.90% <0.00%> (-1.81%) ⬇️
...a/org/apache/rocketmq/broker/BrokerController.java 46.69% <0.00%> (-0.60%) ⬇️
.../org/apache/rocketmq/proxy/config/ProxyConfig.java 48.08% <0.00%> (-0.55%) ⬇️
...cketmq/broker/processor/PopBufferMergeService.java 40.71% <0.00%> (+0.23%) ⬆️
...mq/client/impl/producer/DefaultMQProducerImpl.java 44.62% <0.00%> (+0.24%) ⬆️
...mq/store/ha/autoswitch/AutoSwitchHAConnection.java 75.20% <0.00%> (+0.27%) ⬆️
.../apache/rocketmq/logging/inner/LoggingBuilder.java 64.71% <0.00%> (+0.31%) ⬆️
...nt/impl/consumer/ConsumeMessageOrderlyService.java 50.17% <0.00%> (+0.35%) ⬆️
...he/rocketmq/client/trace/AsyncTraceDispatcher.java 83.80% <0.00%> (+0.47%) ⬆️
... and 7 more

Help us with your feedback. Take ten seconds to tell us how you rate us.

@HScarb
Copy link
Contributor

HScarb commented Jul 30, 2022

Could you squash all the commits to one commit?

@RongtongJin RongtongJin merged commit a94f8ff into apache:develop Jul 30, 2022
@Oliverwqcwrw
Copy link
Member Author

Could you squash all the commits to one commit?

Hello @HScarb ,
Thanks for your suggestion. I will squash it next time when I submit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The error log message is ambiguous

5 participants