Skip to content

Conversation

@RongtongJin
Copy link
Contributor

@RongtongJin RongtongJin commented Jul 31, 2022

Make sure set the target branch to develop

What is the purpose of the change

close #4739
Add TimerMessageStore runtime info in ClusterListSubCommand

Brief changelog

Add TimerMessageStore runtime info in ClusterListSubCommand

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@RongtongJin
Copy link
Contributor Author

@GenerousMan @ShannonDing PTAL~

@codecov-commenter
Copy link

codecov-commenter commented Jul 31, 2022

Codecov Report

Merging #4740 (b3bccb7) into develop (c489a70) will decrease coverage by 0.00%.
The diff coverage is 36.95%.

@@              Coverage Diff              @@
##             develop    #4740      +/-   ##
=============================================
- Coverage      44.83%   44.82%   -0.01%     
- Complexity      7559     7563       +4     
=============================================
  Files            977      977              
  Lines          67641    67695      +54     
  Branches        8934     8936       +2     
=============================================
+ Hits           30325    30345      +20     
- Misses         33578    33603      +25     
- Partials        3738     3747       +9     
Impacted Files Coverage Δ
...q/tools/command/cluster/ClusterListSubCommand.java 0.00% <0.00%> (ø)
...ocketmq/broker/processor/AdminBrokerProcessor.java 26.57% <45.45%> (+0.14%) ⬆️
...apache/rocketmq/store/timer/TimerMessageStore.java 55.19% <60.00%> (+0.12%) ⬆️
...va/org/apache/rocketmq/store/FlushDiskWatcher.java 81.25% <0.00%> (-9.38%) ⬇️
...org/apache/rocketmq/common/stats/StatsItemSet.java 41.79% <0.00%> (-5.98%) ⬇️
...ketmq/common/protocol/body/ConsumerConnection.java 95.83% <0.00%> (-4.17%) ⬇️
...controller/impl/DefaultBrokerHeartbeatManager.java 80.48% <0.00%> (-3.66%) ⬇️
...he/rocketmq/client/trace/AsyncTraceDispatcher.java 81.42% <0.00%> (-2.86%) ⬇️
...mq/client/impl/consumer/RebalanceLitePullImpl.java 69.86% <0.00%> (-1.37%) ⬇️
...he/rocketmq/client/impl/consumer/ProcessQueue.java 61.92% <0.00%> (-0.46%) ⬇️
... and 20 more

Help us with your feedback. Take ten seconds to tell us how you rate us.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 49.08% when pulling b3bccb7 on RongtongJin:develop-zz into e8fd55b on apache:develop.

Copy link
Member

@ShannonDing ShannonDing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShannonDing ShannonDing merged commit e976cdb into apache:develop Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add TimerMessageStore runtime info in ClusterListSubCommand

5 participants