Skip to content

Conversation

@mxsm
Copy link
Member

@mxsm mxsm commented Jul 31, 2022

Make sure set the target branch to develop

What is the purpose of the change

Fix #4746

Brief changelog

  • add controller stand-alone and cluster 3 nodes config file

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 49.032% when pulling 8417bf5 on mxsm:rocketmq-4746 into 58c3af9 on apache:develop.

@codecov-commenter
Copy link

Codecov Report

Merging #4747 (8417bf5) into develop (a64c0f2) will decrease coverage by 0.14%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             develop    #4747      +/-   ##
=============================================
- Coverage      44.83%   44.69%   -0.15%     
+ Complexity      7573     7541      -32     
=============================================
  Files            977      977              
  Lines          67655    67654       -1     
  Branches        8935     8935              
=============================================
- Hits           30331    30235      -96     
- Misses         33586    33670      +84     
- Partials        3738     3749      +11     
Impacted Files Coverage Δ
...rg/apache/rocketmq/common/stats/StatsSnapshot.java 84.61% <0.00%> (-15.39%) ⬇️
.../apache/rocketmq/common/stats/MomentStatsItem.java 38.09% <0.00%> (-9.53%) ⬇️
...q/namesrv/routeinfo/BrokerHousekeepingService.java 72.72% <0.00%> (-9.10%) ⬇️
...ache/rocketmq/common/stats/MomentStatsItemSet.java 39.13% <0.00%> (-8.70%) ⬇️
...a/org/apache/rocketmq/logging/inner/SysLogger.java 28.57% <0.00%> (-5.72%) ⬇️
...org/apache/rocketmq/common/stats/StatsItemSet.java 50.74% <0.00%> (-4.48%) ⬇️
...java/org/apache/rocketmq/logging/inner/Logger.java 51.67% <0.00%> (-4.31%) ⬇️
...va/org/apache/rocketmq/common/stats/StatsItem.java 50.00% <0.00%> (-4.17%) ⬇️
...lient/impl/consumer/DefaultMQPushConsumerImpl.java 31.64% <0.00%> (-3.77%) ⬇️
...ava/org/apache/rocketmq/test/util/VerifyUtils.java 46.26% <0.00%> (-2.99%) ⬇️
... and 19 more

Help us with your feedback. Take ten seconds to tell us how you rate us.

@duhenglucky duhenglucky merged commit 46dd883 into apache:develop Aug 1, 2022
@duhenglucky duhenglucky added this to the 5.0.0 milestone Aug 1, 2022
@mxsm mxsm deleted the rocketmq-4746 branch August 1, 2022 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Conf] Add controller start config file

5 participants