[ISSUE #4810] Correction of spelling mistakes in TimerMessageStore #4811
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lizhanhui
reviewed
Aug 11, 2022
| // The total days in the timer wheel when precision is 1000ms. | ||
| // If the broker shutdown last more than the configured days, will cause message loss | ||
| public static final int TIMER_WHELL_TTL_DAY = 7; | ||
| public static final int TIMER_WHEEL_TTL_DAY = 7; |
Contributor
There was a problem hiding this comment.
To be precise, Rename it to "Timing Wheels". See http://www.cs.columbia.edu/~nahum/w6998/papers/sosp87-timing-wheels.pdf
| this.precisionMs = storeConfig.getTimerPrecisionMs(); | ||
| // TimerWheel contains the fixed number of slots regardless of precision. | ||
| this.slotsTotal = TIMER_WHELL_TTL_DAY * DAY_SECS; | ||
| this.slotsTotal = TIMER_WHEEL_TTL_DAY * DAY_SECS; |
1 similar comment
RongtongJin
changed the title
RongtongJin
approved these changes
Aug 11, 2022
Contributor
|
@RongtongJin DO NOT MERGE the pull request till all issues are resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are several typos in the code.
Like TIMER_WHELL_TTL_DAY in class TimerMessageStore.