[ISSUE #4815] fix reconsuming messages in POP mode taking at least 2min#4816
Merged
RongtongJin merged 1 commit intoapache:developfrom Aug 12, 2022
Merged
[ISSUE #4815] fix reconsuming messages in POP mode taking at least 2min#4816RongtongJin merged 1 commit intoapache:developfrom
RongtongJin merged 1 commit intoapache:developfrom
Conversation
RongtongJin
approved these changes
Aug 12, 2022
Codecov Report
@@ Coverage Diff @@
## develop #4816 +/- ##
=============================================
- Coverage 44.94% 44.93% -0.01%
+ Complexity 7642 7639 -3
=============================================
Files 980 980
Lines 68135 68135
Branches 9014 9014
=============================================
- Hits 30621 30618 -3
- Misses 33732 33733 +1
- Partials 3782 3784 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
1 similar comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure set the target branch to
developWhat is the purpose of the change
fix #4815
Brief changelog
Getting delay level from beginning of
org.apache.rocketmq.client.impl.consumer.DefaultMQPushConsumerImpl#popDelayLevel, instead of from the 4th element (120s).Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice,
it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.[ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyleto make sure basic checks pass. Runmvn clean install -DskipITsto make sure unit-test pass. Runmvn clean test-compile failsafe:integration-testto make sure integration-test pass.