Skip to content

[ISSUE #4815] fix reconsuming messages in POP mode taking at least 2min#4816

Merged
RongtongJin merged 1 commit intoapache:developfrom
caigy:issue-4815
Aug 12, 2022
Merged

[ISSUE #4815] fix reconsuming messages in POP mode taking at least 2min#4816
RongtongJin merged 1 commit intoapache:developfrom
caigy:issue-4815

Conversation

@caigy
Copy link
Contributor

@caigy caigy commented Aug 12, 2022

Make sure set the target branch to develop

What is the purpose of the change

fix #4815

Brief changelog

Getting delay level from beginning of org.apache.rocketmq.client.impl.consumer.DefaultMQPushConsumerImpl#popDelayLevel, instead of from the 4th element (120s).

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@caigy caigy requested a review from RongtongJin August 12, 2022 11:25
@RongtongJin RongtongJin changed the title [ISSSUE #4815] fix reconsuming messages in POP mode taking at least 2min [ISSUE #4815] fix reconsuming messages in POP mode taking at least 2min Aug 12, 2022
@codecov-commenter
Copy link

codecov-commenter commented Aug 12, 2022

Codecov Report

Merging #4816 (c95b33e) into develop (e5a71bb) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@              Coverage Diff              @@
##             develop    #4816      +/-   ##
=============================================
- Coverage      44.94%   44.93%   -0.01%     
+ Complexity      7642     7639       -3     
=============================================
  Files            980      980              
  Lines          68135    68135              
  Branches        9014     9014              
=============================================
- Hits           30621    30618       -3     
- Misses         33732    33733       +1     
- Partials        3782     3784       +2     
Impacted Files Coverage Δ
...consumer/ConsumeMessagePopConcurrentlyService.java 5.70% <0.00%> (ø)
...ava/org/apache/rocketmq/test/util/VerifyUtils.java 46.26% <0.00%> (-2.99%) ⬇️
...mq/client/impl/consumer/RebalanceLitePullImpl.java 69.86% <0.00%> (-1.37%) ⬇️
.../org/apache/rocketmq/proxy/config/ProxyConfig.java 48.90% <0.00%> (-0.55%) ⬇️
...rocketmq/broker/processor/PopMessageProcessor.java 38.19% <0.00%> (-0.55%) ⬇️
...he/rocketmq/client/impl/consumer/ProcessQueue.java 61.92% <0.00%> (-0.46%) ⬇️
.../apache/rocketmq/logging/inner/LoggingBuilder.java 64.39% <0.00%> (-0.32%) ⬇️
...mq/store/ha/autoswitch/AutoSwitchHAConnection.java 74.93% <0.00%> (-0.28%) ⬇️
...org/apache/rocketmq/store/DefaultMessageStore.java 55.53% <0.00%> (-0.24%) ⬇️
...apache/rocketmq/store/timer/TimerMessageStore.java 54.18% <0.00%> (-0.10%) ⬇️
... and 7 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 49.034% when pulling c95b33e on caigy:issue-4815 into e5a71bb on apache:develop.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 49.034% when pulling c95b33e on caigy:issue-4815 into e5a71bb on apache:develop.

@RongtongJin RongtongJin merged commit dbcd37c into apache:develop Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Delay of consuming retry messages in POP mode is too long

4 participants