Skip to content

[ISSUE #4821] Add some integration tests for POP consumption in slave-acting-master mode#4822

Merged
RongtongJin merged 4 commits intoapache:developfrom
caigy:issue-4821
Aug 16, 2022
Merged

[ISSUE #4821] Add some integration tests for POP consumption in slave-acting-master mode#4822
RongtongJin merged 4 commits intoapache:developfrom
caigy:issue-4821

Conversation

@caigy
Copy link
Contributor

@caigy caigy commented Aug 14, 2022

Make sure set the target branch to develop

What is the purpose of the change

fix #4821

Brief changelog

Add PopSlaveActingMasterIT and fix some bugs found.

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@duhenglucky duhenglucky added this to the 5.0.0 milestone Aug 15, 2022
@ShannonDing
Copy link
Member

org.apache.rocketmq.broker.processor.ChangeInvisibleTimeProcessorTest
testProcessRequest_Success(org.apache.rocketmq.broker.processor.ChangeInvisibleTimeProcessorTest) Time elapsed: 2.568 sec <<< ERROR!
java.lang.NullPointerException
at org.apache.rocketmq.broker.processor.ChangeInvisibleTimeProcessorTest.testProcessRequest_Success(ChangeInvisibleTimeProcessorTest.java:122)

@coveralls
Copy link

coveralls commented Aug 16, 2022

Coverage Status

Coverage decreased (-0.1%) to 49.076% when pulling cad0ada on caigy:issue-4821 into 8dd07c8 on apache:develop.

@codecov-commenter
Copy link

Codecov Report

Merging #4822 (22dd251) into develop (8dd07c8) will decrease coverage by 0.11%.
The diff coverage is 40.00%.

❗ Current head 22dd251 differs from pull request most recent head cad0ada. Consider uploading reports for the commit cad0ada to get more accurate results

@@              Coverage Diff              @@
##             develop    #4822      +/-   ##
=============================================
- Coverage      44.94%   44.82%   -0.12%     
  Complexity      7640     7640              
=============================================
  Files            980      982       +2     
  Lines          68135    68239     +104     
  Branches        9014     9025      +11     
=============================================
- Hits           30622    30591      -31     
- Misses         33729    33847     +118     
- Partials        3784     3801      +17     
Impacted Files Coverage Δ
...cketmq/broker/processor/PopBufferMergeService.java 37.67% <0.00%> (-3.04%) ⬇️
...he/rocketmq/broker/processor/PopReviveService.java 38.35% <0.00%> (ø)
...broker/processor/ChangeInvisibleTimeProcessor.java 66.97% <100.00%> (+1.83%) ⬆️
...rocketmq/broker/processor/PopMessageProcessor.java 38.17% <100.00%> (-0.57%) ⬇️
...va/org/apache/rocketmq/store/FlushDiskWatcher.java 81.25% <0.00%> (-9.38%) ⬇️
...controller/impl/DefaultBrokerHeartbeatManager.java 71.26% <0.00%> (-9.23%) ⬇️
...q/namesrv/routeinfo/BrokerHousekeepingService.java 72.72% <0.00%> (-9.10%) ⬇️
...a/org/apache/rocketmq/logging/inner/SysLogger.java 28.57% <0.00%> (-5.72%) ⬇️
...etmq/namesrv/routeinfo/BatchUnRegisterService.java 94.73% <0.00%> (-5.27%) ⬇️
...java/org/apache/rocketmq/logging/inner/Logger.java 51.67% <0.00%> (-4.31%) ⬇️
... and 39 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@RongtongJin RongtongJin merged commit e3c2111 into apache:develop Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add integration tests for POP consumption when slave is acting master

6 participants