Skip to content

Conversation

@mxsm
Copy link
Member

@mxsm mxsm commented Aug 20, 2022

Make sure set the target branch to develop

What is the purpose of the change

Fix #4851

Brief changelog

  • Fix HAService implement class some method miss @OverRide annotation

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@codecov-commenter
Copy link

codecov-commenter commented Aug 20, 2022

Codecov Report

Merging #4852 (2edf6ff) into develop (97521a3) will increase coverage by 0.02%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             develop    #4852      +/-   ##
=============================================
+ Coverage      44.91%   44.93%   +0.02%     
- Complexity      7664     7673       +9     
=============================================
  Files            982      982              
  Lines          68253    68253              
  Branches        9023     9023              
=============================================
+ Hits           30653    30669      +16     
+ Misses         33809    33805       -4     
+ Partials        3791     3779      -12     
Impacted Files Coverage Δ
...org/apache/rocketmq/store/ha/DefaultHAService.java 67.48% <ø> (ø)
...ketmq/store/ha/autoswitch/AutoSwitchHAService.java 56.06% <ø> (ø)
...mq/broker/topic/TopicQueueMappingCleanService.java 12.43% <0.00%> (-3.63%) ⬇️
.../rocketmq/broker/filter/ConsumerFilterManager.java 72.19% <0.00%> (-1.80%) ⬇️
...ava/org/apache/rocketmq/filter/util/BitsArray.java 60.68% <0.00%> (-1.71%) ⬇️
...a/org/apache/rocketmq/store/StoreStatsService.java 50.27% <0.00%> (-0.56%) ⬇️
...cketmq/store/ha/autoswitch/AutoSwitchHAClient.java 75.84% <0.00%> (-0.38%) ⬇️
...rocketmq/remoting/netty/NettyRemotingAbstract.java 53.95% <0.00%> (-0.36%) ⬇️
...org/apache/rocketmq/store/DefaultMessageStore.java 55.77% <0.00%> (+0.15%) ⬆️
...nt/impl/consumer/ConsumeMessageOrderlyService.java 49.82% <0.00%> (+0.35%) ⬆️
... and 10 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@coveralls
Copy link

Coverage Status

Coverage remained the same at 49.022% when pulling 2edf6ff on mxsm:rocketmq-4851 into 97521a3 on apache:develop.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 49.022% when pulling 2edf6ff on mxsm:rocketmq-4851 into 97521a3 on apache:develop.

@RongtongJin RongtongJin merged commit 96fd4f5 into apache:develop Aug 21, 2022
@mxsm mxsm deleted the rocketmq-4851 branch August 21, 2022 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

HAService implement class some method miss @Override annotation

4 participants