Skip to content

Conversation

@RongtongJin
Copy link
Contributor

Make sure set the target branch to develop

What is the purpose of the change

Add example of timing messages with arbitrary time delay

Brief changelog

Add example of timing messages with arbitrary time delay

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@RongtongJin
Copy link
Contributor Author

Hi, @GenerousMan PTAL~

@codecov-commenter
Copy link

codecov-commenter commented Aug 21, 2022

Codecov Report

Merging #4856 (ea9a91d) into develop (96fd4f5) will increase coverage by 0.13%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             develop    #4856      +/-   ##
=============================================
+ Coverage      44.80%   44.93%   +0.13%     
- Complexity      7637     7666      +29     
=============================================
  Files            982      982              
  Lines          68253    68253              
  Branches        9023     9023              
=============================================
+ Hits           30580    30671      +91     
+ Misses         33884    33799      -85     
+ Partials        3789     3783       -6     
Impacted Files Coverage Δ
...org/apache/rocketmq/common/stats/StatsItemSet.java 43.28% <0.00%> (-7.47%) ⬇️
...ent/impl/consumer/DefaultLitePullConsumerImpl.java 70.48% <0.00%> (ø)
...org/apache/rocketmq/store/DefaultMessageStore.java 55.77% <0.00%> (+0.23%) ⬆️
...mq/store/ha/autoswitch/AutoSwitchHAConnection.java 75.20% <0.00%> (+0.27%) ⬆️
...rocketmq/client/impl/factory/MQClientInstance.java 47.30% <0.00%> (+0.27%) ⬆️
...e/rocketmq/namesrv/routeinfo/RouteInfoManager.java 65.69% <0.00%> (+0.30%) ⬆️
.../apache/rocketmq/logging/inner/LoggingBuilder.java 64.71% <0.00%> (+0.31%) ⬆️
...he/rocketmq/remoting/protocol/RemotingCommand.java 68.40% <0.00%> (+0.34%) ⬆️
...ocketmq/client/consumer/DefaultMQPushConsumer.java 58.10% <0.00%> (+0.45%) ⬆️
...pl/consumer/ConsumeMessageConcurrentlyService.java 48.14% <0.00%> (+0.46%) ⬆️
... and 20 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.07%) to 48.996% when pulling ea9a91d on RongtongJin:add_timer_message_example into 96fd4f5 on apache:develop.

@coveralls
Copy link

coveralls commented Aug 21, 2022

Coverage Status

Coverage increased (+0.1%) to 49.182% when pulling ea9a91d on RongtongJin:add_timer_message_example into 96fd4f5 on apache:develop.

@duhenglucky duhenglucky merged commit 58c1d1e into apache:develop Aug 22, 2022
@duhenglucky duhenglucky added this to the 5.0.0 milestone Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants