Skip to content

Conversation

@mxsm
Copy link
Member

@mxsm mxsm commented Aug 28, 2022

Make sure set the target branch to develop

What is the purpose of the change

close #4913

Brief changelog

-ReplicasManager#schedulingSyncControllerMetadata update controller metadata again after a while

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@codecov-commenter
Copy link

codecov-commenter commented Aug 28, 2022

Codecov Report

Merging #4914 (2b8b8da) into develop (244959c) will decrease coverage by 0.07%.
The diff coverage is 0.00%.

@@              Coverage Diff              @@
##             develop    #4914      +/-   ##
=============================================
- Coverage      43.30%   43.23%   -0.08%     
+ Complexity      7701     7696       -5     
=============================================
  Files            994      994              
  Lines          68939    68942       +3     
  Branches        9132     9132              
=============================================
- Hits           29853    29806      -47     
- Misses         35341    35389      +48     
- Partials        3745     3747       +2     
Impacted Files Coverage Δ
...he/rocketmq/broker/controller/ReplicasManager.java 43.09% <0.00%> (-0.55%) ⬇️
...va/org/apache/rocketmq/logging/inner/Appender.java 29.21% <0.00%> (-7.87%) ⬇️
...etmq/namesrv/routeinfo/BatchUnRegisterService.java 94.73% <0.00%> (-5.27%) ⬇️
...a/org/apache/rocketmq/broker/BrokerController.java 43.84% <0.00%> (-3.52%) ⬇️
...he/rocketmq/broker/processor/PopReviveService.java 38.35% <0.00%> (-1.80%) ⬇️
...ava/org/apache/rocketmq/filter/util/BitsArray.java 58.11% <0.00%> (-1.71%) ⬇️
...e/rocketmq/client/impl/consumer/RebalanceImpl.java 31.44% <0.00%> (-0.84%) ⬇️
...ent/impl/consumer/DefaultLitePullConsumerImpl.java 69.21% <0.00%> (-0.16%) ⬇️
.../apache/rocketmq/logging/inner/LoggingBuilder.java 63.76% <0.00%> (+0.15%) ⬆️
... and 6 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

…update controller metadata again after a while
@RongtongJin RongtongJin merged commit cf74c3c into apache:develop Aug 29, 2022
@mxsm mxsm deleted the rocketmq-4913 branch August 29, 2022 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ReplicasManager#schedulingSyncControllerMetadata update controller metadata again after a while

4 participants