Skip to content

[ISSUE #4936] Remove useless log output after the master and slave broker are started on the empty disk in controller mode#4944

Merged
ShannonDing merged 2 commits intoapache:developfrom
RongtongJin:fix_4936
Aug 31, 2022
Merged

[ISSUE #4936] Remove useless log output after the master and slave broker are started on the empty disk in controller mode#4944
ShannonDing merged 2 commits intoapache:developfrom
RongtongJin:fix_4936

Conversation

@RongtongJin
Copy link
Contributor

Make sure set the target branch to develop

What is the purpose of the change

Remove useless log output after the master and slave broker are started on the empty disk in controller mode

image

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@RongtongJin RongtongJin requested a review from hzh0425 August 31, 2022 07:00
@codecov-commenter
Copy link

Codecov Report

Merging #4944 (03ff645) into develop (4661e58) will increase coverage by 0.04%.
The diff coverage is 0.00%.

@@              Coverage Diff              @@
##             develop    #4944      +/-   ##
=============================================
+ Coverage      43.11%   43.16%   +0.04%     
+ Complexity      7686     7683       -3     
=============================================
  Files            995      995              
  Lines          68963    68966       +3     
  Branches        9136     9138       +2     
=============================================
+ Hits           29735    29770      +35     
+ Misses         35495    35460      -35     
- Partials        3733     3736       +3     
Impacted Files Coverage Δ
.../apache/rocketmq/broker/failover/EscapeBridge.java 33.12% <0.00%> (+0.40%) ⬆️
...mq/store/ha/autoswitch/AutoSwitchHAConnection.java 71.77% <0.00%> (+0.65%) ⬆️
...org/apache/rocketmq/common/stats/StatsItemSet.java 41.79% <0.00%> (-8.96%) ⬇️
...ache/rocketmq/common/stats/MomentStatsItemSet.java 39.13% <0.00%> (-4.35%) ⬇️
...ketmq/client/impl/consumer/PullMessageService.java 49.23% <0.00%> (-3.08%) ⬇️
...he/rocketmq/controller/impl/DLedgerController.java 68.06% <0.00%> (-2.62%) ⬇️
.../apache/rocketmq/controller/ControllerManager.java 73.11% <0.00%> (-2.16%) ⬇️
...apache/rocketmq/remoting/netty/ResponseFuture.java 79.59% <0.00%> (-2.05%) ⬇️
...rocketmq/remoting/netty/NettyRemotingAbstract.java 52.51% <0.00%> (-1.44%) ⬇️
...mq/client/impl/consumer/RebalanceLitePullImpl.java 69.86% <0.00%> (-1.37%) ⬇️
... and 16 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ShannonDing ShannonDing added this to the 5.0.0 milestone Aug 31, 2022
@ShannonDing ShannonDing merged commit 516e0d7 into apache:develop Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants