Skip to content

Conversation

@mxsm
Copy link
Member

@mxsm mxsm commented Sep 4, 2022

Make sure set the target branch to develop

What is the purpose of the change

Fix #4987

Brief changelog

  • fix test case:PlainAccessValidatorTest#testUpdateSpecifiedAclFileGlobalWhiteAddrsConfig

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@codecov-commenter
Copy link

Codecov Report

Merging #4988 (2cc06af) into develop (8517a5d) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             develop    #4988      +/-   ##
=============================================
- Coverage      43.19%   43.19%   -0.01%     
+ Complexity      7724     7723       -1     
=============================================
  Files            995      995              
  Lines          69066    69066              
  Branches        9143     9143              
=============================================
- Hits           29834    29830       -4     
- Misses         35487    35495       +8     
+ Partials        3745     3741       -4     
Impacted Files Coverage Δ
...apache/rocketmq/remoting/netty/ResponseFuture.java 77.55% <0.00%> (-4.09%) ⬇️
...rocketmq/remoting/netty/NettyRemotingAbstract.java 50.00% <0.00%> (-3.96%) ⬇️
...apache/rocketmq/store/ha/GroupTransferService.java 92.30% <0.00%> (-1.29%) ⬇️
.../org/apache/rocketmq/store/ha/DefaultHAClient.java 61.02% <0.00%> (-0.52%) ⬇️
...he/rocketmq/client/impl/consumer/ProcessQueue.java 61.46% <0.00%> (-0.46%) ⬇️
...cketmq/store/ha/autoswitch/AutoSwitchHAClient.java 75.47% <0.00%> (-0.38%) ⬇️
...cketmq/broker/processor/PopBufferMergeService.java 37.67% <0.00%> (+0.23%) ⬆️
...mq/store/ha/autoswitch/AutoSwitchHAConnection.java 70.43% <0.00%> (+0.26%) ⬆️
...nt/impl/consumer/ConsumeMessageOrderlyService.java 50.17% <0.00%> (+0.35%) ⬆️
...ent/impl/consumer/DefaultLitePullConsumerImpl.java 69.21% <0.00%> (+0.46%) ⬆️
... and 4 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@RongtongJin RongtongJin merged commit 4f0636a into apache:develop Sep 5, 2022
@mxsm mxsm deleted the rocketmq-4987 branch September 5, 2022 01:45
@duhenglucky duhenglucky added this to the 5.0.0 milestone Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix test case: PlainAccessValidatorTest#testUpdateSpecifiedAclFileGlobalWhiteAddrsConfig

4 participants