Skip to content

[ISSUE#5015]Fix typo of getAllCongestNum in TimerMessageStore#5016

Merged
RongtongJin merged 1 commit intoapache:developfrom
zhiliatom:fix_typo_getAllCongestNum
Sep 8, 2022
Merged

[ISSUE#5015]Fix typo of getAllCongestNum in TimerMessageStore#5016
RongtongJin merged 1 commit intoapache:developfrom
zhiliatom:fix_typo_getAllCongestNum

Conversation

@zhiliatom
Copy link
Contributor

Make sure set the target branch to develop

What is the purpose of the change

fix #5015

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@codecov-commenter
Copy link

Codecov Report

Merging #5016 (146b3e5) into develop (831888d) will increase coverage by 0.03%.
The diff coverage is 0.00%.

@@              Coverage Diff              @@
##             develop    #5016      +/-   ##
=============================================
+ Coverage      43.24%   43.28%   +0.03%     
- Complexity      7766     7769       +3     
=============================================
  Files            995      995              
  Lines          69101    69101              
  Branches        9154     9154              
=============================================
+ Hits           29883    29908      +25     
+ Misses         35465    35439      -26     
- Partials        3753     3754       +1     
Impacted Files Coverage Δ
...ocketmq/broker/processor/AdminBrokerProcessor.java 26.57% <0.00%> (ø)
...apache/rocketmq/store/timer/TimerMessageStore.java 54.18% <0.00%> (ø)
...apache/rocketmq/broker/longpolling/PopRequest.java 31.03% <0.00%> (-13.80%) ⬇️
...org/apache/rocketmq/common/stats/StatsItemSet.java 41.79% <0.00%> (-8.96%) ⬇️
...he/rocketmq/controller/impl/DLedgerController.java 66.49% <0.00%> (-2.62%) ⬇️
...ache/rocketmq/proxy/common/ReceiptHandleGroup.java 65.06% <0.00%> (-1.21%) ⬇️
.../apache/rocketmq/store/ha/DefaultHAConnection.java 65.86% <0.00%> (-1.21%) ⬇️
...ache/rocketmq/broker/client/ConsumerGroupInfo.java 68.46% <0.00%> (-0.91%) ⬇️
...ava/org/apache/rocketmq/store/index/IndexFile.java 73.68% <0.00%> (-0.88%) ⬇️
.../org/apache/rocketmq/store/ha/DefaultHAClient.java 61.53% <0.00%> (-0.52%) ⬇️
... and 9 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@RongtongJin RongtongJin merged commit f1e95cd into apache:develop Sep 8, 2022
@duhenglucky duhenglucky added this to the 5.0.0 milestone Sep 14, 2022
@zhiliatom zhiliatom deleted the fix_typo_getAllCongestNum branch September 23, 2022 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix typo of getAllCongestNum in TimerMessageStore

6 participants