Skip to content

Conversation

@echooymxq
Copy link
Contributor

Make sure set the target branch to develop

What is the purpose of the change

XXXXX

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@codecov-commenter
Copy link

Codecov Report

Merging #5044 (77a52e5) into develop (f8bf7bd) will decrease coverage by 0.03%.
The diff coverage is 37.50%.

@@              Coverage Diff              @@
##             develop    #5044      +/-   ##
=============================================
- Coverage      43.21%   43.18%   -0.04%     
+ Complexity      7764     7756       -8     
=============================================
  Files            995      995              
  Lines          69113    69115       +2     
  Branches        9152     9152              
=============================================
- Hits           29869    29846      -23     
- Misses         35490    35507      +17     
- Partials        3754     3762       +8     
Impacted Files Coverage Δ
...sumer/rebalance/AllocateMessageQueueAveragely.java 78.94% <0.00%> (+3.94%) ⬆️
...balance/AllocateMessageQueueAveragelyByCircle.java 78.57% <0.00%> (+5.23%) ⬆️
...ebalance/AbstractAllocateMessageQueueStrategy.java 81.25% <50.00%> (-18.75%) ⬇️
...ketmq/common/protocol/body/ConsumerConnection.java 95.83% <0.00%> (-4.17%) ⬇️
...apache/rocketmq/remoting/netty/ResponseFuture.java 77.55% <0.00%> (-4.09%) ⬇️
...rocketmq/remoting/netty/NettyRemotingAbstract.java 49.27% <0.00%> (-3.63%) ⬇️
...ketmq/proxy/grpc/v2/channel/GrpcClientChannel.java 56.04% <0.00%> (-3.30%) ⬇️
...e/rocketmq/remoting/netty/NettyRemotingClient.java 41.09% <0.00%> (-2.64%) ⬇️
.../apache/rocketmq/controller/ControllerManager.java 73.11% <0.00%> (-2.16%) ⬇️
...va/org/apache/rocketmq/store/util/PerfCounter.java 64.39% <0.00%> (-2.10%) ⬇️
... and 15 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@RongtongJin RongtongJin merged commit c820a68 into apache:develop Sep 13, 2022
@duhenglucky duhenglucky added this to the 5.0.0 milestone Sep 14, 2022
@echooymxq echooymxq deleted the broker_logger branch October 12, 2022 08:43
cserwen pushed a commit to cserwen/rocketmq that referenced this pull request Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants