Skip to content

[ISSUE #5147] Fix ClassNotFoundException#5148

Closed
Oliverwqcwrw wants to merge 1 commit intoapache:developfrom
Oliverwqcwrw:develop-fix-classnotfound-45
Closed

[ISSUE #5147] Fix ClassNotFoundException#5148
Oliverwqcwrw wants to merge 1 commit intoapache:developfrom
Oliverwqcwrw:develop-fix-classnotfound-45

Conversation

@Oliverwqcwrw
Copy link
Copy Markdown
Member

Make sure set the target branch to develop

What is the purpose of the change

Close #5147

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

Copy link
Copy Markdown
Contributor

@caigy caigy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drpmma
Copy link
Copy Markdown
Contributor

drpmma commented Sep 21, 2022

The opentracing should not be explicitly introduced in maven, otherwise, it may cause version conflict. Instead, you should introduce it in your own project.

@ShadowySpirits
Copy link
Copy Markdown
Member

The opentracing should not be explicitly introduced in maven, otherwise, it may cause version conflict. Instead, you should introduce it in your own project.

agree with

@aaron-ai
Copy link
Copy Markdown
Member

Actually OpenTracing is archived, you can see more details from here, we may remove the dependency of OpenTracing in the near future.

Copy link
Copy Markdown
Contributor

@drpmma drpmma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The opentracing should not be explicitly introduced in maven, otherwise, it may cause version conflict. Instead, you should introduce it in your own project.

@Oliverwqcwrw
Copy link
Copy Markdown
Member Author

Hello @caigy , @drpmma , @ShadowySpirits , @aaron-ai
thx for your reply, get it
I will manually add opentracing-api to the classpath

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

java.lang.NoClassDefFoundError: io/opentracing/Tracer

5 participants