[ISSUE #5472] Add the annotation @Deprecated to the methods that are not used in Class "MonitorService" #5476
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ISSUE apache#5168] Release 5.0.0 merge release-5.0.0 to master
…ass "MonitorService"
Contributor
tsunghanjacktsai
left a comment
tsunghanjacktsai
left a comment
There was a problem hiding this comment.
@jasonjavaYY Please keep your local branch updated with the upstream one and only include the necessary commit.
|
This PR is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. If you wish not to mark it as stale, please leave a comment in this PR. |
|
This PR was closed because it has been inactive for 3 days since being marked as stale. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
There is no call to Class “org.apache.rocketmq.tools.monitor.MonitorService” startup method in the scripts under the “bin directory”, which means that the main method of class “MonitorService” will not be executed, so I add the annotation @deprecated to the methods that are not used in Class "MonitorService".
Brief changelog
Add the annotation @deprecated to the methods that are not used in Class "MonitorService".
Verifying this change
Trivial changes: This pr only adds the annotation @deprecated and does not involve logic code modification.
I have run mvn clean install to make sure unit-test pass.