Bugfix/issue 552#553
Closed
francisoliverlee wants to merge 2 commits intoapache:masterfrom
francisoliverlee:bugfix/issue-552-2018-12-21
Closed
Bugfix/issue 552#553francisoliverlee wants to merge 2 commits intoapache:masterfrom francisoliverlee:bugfix/issue-552-2018-12-21
francisoliverlee wants to merge 2 commits intoapache:masterfrom
francisoliverlee:bugfix/issue-552-2018-12-21
Conversation
|
|
||
| // consumerGroup | ||
| if (null == this.defaultMQPullConsumer.getConsumerGroup()) { | ||
| if (UtilAll.isBlank(this.defaultMQPullConsumer.getConsumerGroup())) { |
Contributor
There was a problem hiding this comment.
Maybe we should keep isBlank() check in checkGroup() and add FAQUrl.suggestTodo, and remove the null check after checkGroup(), in order to reduce duplicated code.
247e0bf to
ce4478a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
redundant consumer group check
What is the purpose of the change
issue fix
#552
Brief changelog
client/src/main/java/org/apache/rocketmq/client/Validators.java checkGroup()
client/src/main/java/org/apache/rocketmq/client/impl/consumer/DefaultMQPullConsumerImpl.java checkConfig()
client/src/main/java/org/apache/rocketmq/client/impl/consumer/DefaultMQPushConsumerImpl.java checkConfig()
client/src/main/java/org/apache/rocketmq/client/impl/producer/DefaultMQProducerImpl.java checkConfig()
Verifying this change
check code
Follow this checklist to help us incorporate your contribution quickly and easily. Notice,
it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.[ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyleto make sure basic checks pass. Runmvn clean install -DskipITsto make sure unit-test pass. Runmvn clean test-compile failsafe:integration-testto make sure integration-test pass.