Skip to content

Bugfix/issue 552#553

Closed
francisoliverlee wants to merge 2 commits intoapache:masterfrom
francisoliverlee:bugfix/issue-552-2018-12-21
Closed

Bugfix/issue 552#553
francisoliverlee wants to merge 2 commits intoapache:masterfrom
francisoliverlee:bugfix/issue-552-2018-12-21

Conversation

@francisoliverlee
Copy link
Copy Markdown
Member

@francisoliverlee francisoliverlee commented Nov 20, 2018

redundant consumer group check

What is the purpose of the change

issue fix
#552

Brief changelog

client/src/main/java/org/apache/rocketmq/client/Validators.java checkGroup()
client/src/main/java/org/apache/rocketmq/client/impl/consumer/DefaultMQPullConsumerImpl.java checkConfig()
client/src/main/java/org/apache/rocketmq/client/impl/consumer/DefaultMQPushConsumerImpl.java checkConfig()
client/src/main/java/org/apache/rocketmq/client/impl/producer/DefaultMQProducerImpl.java checkConfig()

image

Verifying this change

check code

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

white tiger added 2 commits November 21, 2018 01:06
redundant consumer group check
redundant consumer group check
@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.1%) to 43.209% when pulling 40b932f on francisoliverlee:bugfix/issue-552-2018-12-21 into 1bedba8 on apache:master.


// consumerGroup
if (null == this.defaultMQPullConsumer.getConsumerGroup()) {
if (UtilAll.isBlank(this.defaultMQPullConsumer.getConsumerGroup())) {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should keep isBlank() check in checkGroup() and add FAQUrl.suggestTodo, and remove the null check after checkGroup(), in order to reduce duplicated code.

@vongosling vongosling force-pushed the master branch 2 times, most recently from 247e0bf to ce4478a Compare October 12, 2019 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants