Skip to content

Conversation

@zhangjidi2016
Copy link
Contributor

Make sure set the target branch to develop

What is the purpose of the change

#5303

In #5304 , there were two failed CI projects below, but they could not be reexecuted and one was resubmitted

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@zhangjidi2016 zhangjidi2016 requested review from caigy and drpmma and removed request for caigy November 28, 2022 09:08
@codecov-commenter
Copy link

Codecov Report

Merging #5608 (7883c2d) into develop (08dbe7e) will increase coverage by 0.05%.
The diff coverage is 9.09%.

@@              Coverage Diff              @@
##             develop    #5608      +/-   ##
=============================================
+ Coverage      42.37%   42.43%   +0.05%     
- Complexity      7929     7942      +13     
=============================================
  Files           1022     1022              
  Lines          71254    71261       +7     
  Branches        9399     9399              
=============================================
+ Hits           30196    30241      +45     
+ Misses         37230    37201      -29     
+ Partials        3828     3819       -9     
Impacted Files Coverage Δ
...apache/rocketmq/acl/plain/PlainAccessResource.java 57.57% <ø> (ø)
...broker/processor/AbstractSendMessageProcessor.java 33.43% <ø> (ø)
...ocketmq/broker/processor/PullMessageProcessor.java 27.72% <ø> (ø)
...ocketmq/broker/processor/SendMessageProcessor.java 37.39% <ø> (ø)
.../apache/rocketmq/common/AbortProcessException.java 0.00% <ø> (ø)
.../java/org/apache/rocketmq/common/BrokerConfig.java 28.03% <ø> (-0.12%) ⬇️
...rocketmq/remoting/netty/NettyRemotingAbstract.java 51.92% <9.09%> (+1.92%) ⬆️
...rocketmq/common/message/MessageClientIDSetter.java 71.42% <0.00%> (-2.39%) ⬇️
...apache/rocketmq/store/ha/GroupTransferService.java 92.30% <0.00%> (-1.29%) ⬇️
... and 20 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@lizhanhui lizhanhui merged commit a17991b into apache:develop Nov 30, 2022
@zhangjidi2016 zhangjidi2016 deleted the fix_batchSend_acl branch November 30, 2022 07:45
lizhimins pushed a commit to lizhimins/rocketmq that referenced this pull request Dec 2, 2022
…ding batch messages (apache#5608)

Co-authored-by: zhangjidi <zhangjidi@cmss.chinamobile.com>
Langkeren pushed a commit to Langkeren/rocketmq that referenced this pull request Jan 3, 2023
…ding batch messages (apache#5608)

Co-authored-by: zhangjidi <zhangjidi@cmss.chinamobile.com>
drpmma pushed a commit that referenced this pull request Feb 21, 2023
…atch messages (#5608)

Co-authored-by: zhangjidi <zhangjidi@cmss.chinamobile.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants