Skip to content

Conversation

@drpmma
Copy link
Contributor

@drpmma drpmma commented Dec 1, 2022

What is the purpose of the change

Optimize proxy interface and method

Brief changelog

  • Add popMessage AddressableMessageQueue interface

  • Change ClusterMessageService field to protected

  • Add notification in MQClientAPIExt

Copy link
Contributor

@lollipopjin lollipopjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

codecov-commenter commented Dec 1, 2022

Codecov Report

Attention: Patch coverage is 8.69565% with 21 lines in your changes missing coverage. Please review.

Project coverage is 42.43%. Comparing base (d3de48c) to head (5e12d3b).
Report is 992 commits behind head on develop.

Files with missing lines Patch % Lines
...ocketmq/proxy/service/mqclient/MQClientAPIExt.java 0.00% 18 Missing ⚠️
...he/rocketmq/proxy/processor/ConsumerProcessor.java 40.00% 3 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #5628      +/-   ##
=============================================
- Coverage      42.46%   42.43%   -0.04%     
- Complexity      7971     7972       +1     
=============================================
  Files           1023     1023              
  Lines          71449    71477      +28     
  Branches        9439     9444       +5     
=============================================
- Hits           30340    30330      -10     
- Misses         37276    37308      +32     
- Partials        3833     3839       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@drpmma drpmma merged commit 9b1b625 into apache:develop Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants