-
Notifications
You must be signed in to change notification settings - Fork 12k
[ISSUE #5688]Add log xml config file into distribution config directory #5689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ni-ze
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
file rmq.tools.logback.xml also should be include.
|
No, we don't need to add configuration file into the distribution directory because it has been included by the generated jar. |
@aaron-ai IMO, it has been included by the generated jar, but if O&M wants to change the log level, they can't. So I think should add those files into the distribution directory. It is convenient to modify the log level and log output position dynamically.I think these files should be included for binary packages. |
Keeping a copy is not a good practice to maintain the configuration file, consider to copy it in compile stage if you really want to keep a copy in the distribution directory. |
That's a good idea, I will try |
|
@aaron-ai PTAL~ |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #5689 +/- ##
=============================================
+ Coverage 42.35% 42.46% +0.11%
- Complexity 8192 8211 +19
=============================================
Files 1060 1060
Lines 73108 73108
Branches 9586 9586
=============================================
+ Hits 30962 31044 +82
+ Misses 38234 38156 -78
+ Partials 3912 3908 -4 ☔ View full report in Codecov by Sentry. |
|
Well done! thx @mxsm |

Make sure set the target branch to
developWhat is the purpose of the change
close #5688
Brief changelog
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice,
it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.[ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyleto make sure basic checks pass. Runmvn clean install -DskipITsto make sure unit-test pass. Runmvn clean test-compile failsafe:integration-testto make sure integration-test pass.