Skip to content

Conversation

@mxsm
Copy link
Member

@mxsm mxsm commented Dec 11, 2022

Make sure set the target branch to develop

What is the purpose of the change

close #5688

Brief changelog

  • Add log xml config file into distribution config directory

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

Copy link
Contributor

@ni-ze ni-ze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

file rmq.tools.logback.xml also should be include.

@aaron-ai
Copy link
Member

No, we don't need to add configuration file into the distribution directory because it has been included by the generated jar.

@mxsm
Copy link
Member Author

mxsm commented Dec 12, 2022

No, we don't need to add configuration file into the distribution directory because it has been included by the generated jar.

@aaron-ai IMO, it has been included by the generated jar, but if O&M wants to change the log level, they can't. So I think should add those files into the distribution directory. It is convenient to modify the log level and log output position dynamically.I think these files should be included for binary packages.

@aaron-ai
Copy link
Member

aaron-ai commented Dec 13, 2022

No, we don't need to add configuration file into the distribution directory because it has been included by the generated jar.

@aaron-ai IMO, it has been included by the generated jar, but if O&M wants to change the log level, they can't. So I think should add those files into the distribution directory. It is convenient to modify the log level and log output position dynamically.I think these files should be included for binary packages.

Keeping a copy is not a good practice to maintain the configuration file, consider to copy it in compile stage if you really want to keep a copy in the distribution directory.

@mxsm
Copy link
Member Author

mxsm commented Dec 13, 2022

No, we don't need to add configuration file into the distribution directory because it has been included by the generated jar.

@aaron-ai IMO, it has been included by the generated jar, but if O&M wants to change the log level, they can't. So I think should add those files into the distribution directory. It is convenient to modify the log level and log output position dynamically.I think these files should be included for binary packages.

Keeping a copy is not a good practice to maintain the configuration file, consider to copy it in compile stage if you really want to keep a copy in the distribution directory.

That's a good idea, I will try

@mxsm
Copy link
Member Author

mxsm commented Dec 15, 2022

@aaron-ai PTAL~
I have build on windows platform:
image

@codecov-commenter
Copy link

codecov-commenter commented Dec 15, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.46%. Comparing base (aa7a442) to head (fd3c338).
Report is 933 commits behind head on develop.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #5689      +/-   ##
=============================================
+ Coverage      42.35%   42.46%   +0.11%     
- Complexity      8192     8211      +19     
=============================================
  Files           1060     1060              
  Lines          73108    73108              
  Branches        9586     9586              
=============================================
+ Hits           30962    31044      +82     
+ Misses         38234    38156      -78     
+ Partials        3912     3908       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aaron-ai
Copy link
Member

Well done! thx @mxsm

@RongtongJin RongtongJin merged commit 7bd02db into apache:develop Dec 16, 2022
@mxsm mxsm deleted the rocketmq-5688 branch December 16, 2022 07:50
Langkeren pushed a commit to Langkeren/rocketmq that referenced this pull request Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add log xml config file into distribution config directory

5 participants