-
Notifications
You must be signed in to change notification settings - Fork 12k
[ISSUE #5800] Fix start producer.sh can't find java execute file #5801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #5801 +/- ##
=============================================
- Coverage 42.38% 42.37% -0.01%
+ Complexity 8223 8220 -3
=============================================
Files 1060 1060
Lines 73374 73374
Branches 9602 9602
=============================================
- Hits 31096 31092 -4
- Misses 38364 38367 +3
- Partials 3914 3915 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
| JAVA_HOME=$(/usr/libexec/java_home) | ||
| ;; | ||
| *) | ||
| JAVA_HOME=$(dirname $(dirname $(readlink -f $(which javac)))) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It will get an error if which javac get nothing.
| find_java_home | ||
|
|
||
| if [ -z "$JAVA_HOME" ]; then | ||
| JAVA_HOME=/usr/java |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function find_java_home should be executed only if JAVA_HOME is null. Otherwise, user-specified JAVA_HOME will be overwritten.
|
Set your JAVA_HOME=/usr/lib/jvm/java-1.8.0-openjdk-1.8.0.352.b08-2.al8.x86_64/jre, this error maybe resolved. |
|
This PR is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. If you wish not to mark it as stale, please leave a comment in this PR. |
|
This PR was closed because it has been inactive for 3 days since being marked as stale. |
Make sure set the target branch to
developWhat is the purpose of the change
close #5800
Brief changelog
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice,
it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.[ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyleto make sure basic checks pass. Runmvn clean install -DskipITsto make sure unit-test pass. Runmvn clean test-compile failsafe:integration-testto make sure integration-test pass.