Skip to content

Conversation

@RongtongJin
Copy link
Contributor

Make sure set the target branch to develop

What is the purpose of the change

Ignore testChangeRoleManyTimes in AutoSwitchHATest util it is stable

Brief changelog

Ignore testChangeRoleManyTimes in AutoSwitchHATest util it is stable

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@RongtongJin RongtongJin changed the title Ignore testChangeRoleManyTimes in AutoSwitchHATest util it is stable [ISSUE #5872] Ignore testChangeRoleManyTimes in AutoSwitchHATest util it is stable Jan 12, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #5871 (41fa447) into develop (7c128a5) will decrease coverage by 0.08%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             develop    #5871      +/-   ##
=============================================
- Coverage      42.51%   42.43%   -0.09%     
+ Complexity      8259     8237      -22     
=============================================
  Files           1060     1060              
  Lines          73501    73501              
  Branches        9622     9622              
=============================================
- Hits           31249    31190      -59     
- Misses         38330    38377      +47     
- Partials        3922     3934      +12     
Impacted Files Coverage Δ
...org/apache/rocketmq/common/stats/StatsItemSet.java 41.79% <0.00%> (-8.96%) ⬇️
...e/rocketmq/store/ha/autoswitch/EpochFileCache.java 77.08% <0.00%> (-4.17%) ⬇️
...ketmq/proxy/grpc/v2/channel/GrpcClientChannel.java 49.07% <0.00%> (-2.78%) ⬇️
...mq/store/ha/autoswitch/AutoSwitchHAConnection.java 70.00% <0.00%> (-2.71%) ⬇️
...va/org/apache/rocketmq/common/stats/StatsItem.java 50.00% <0.00%> (-2.50%) ⬇️
...ache/rocketmq/proxy/common/ReceiptHandleGroup.java 65.30% <0.00%> (-2.05%) ⬇️
...ava/org/apache/rocketmq/filter/util/BitsArray.java 58.11% <0.00%> (-1.71%) ⬇️
...he/rocketmq/client/trace/AsyncTraceDispatcher.java 82.21% <0.00%> (-1.45%) ⬇️
...he/rocketmq/broker/processor/PopReviveService.java 39.62% <0.00%> (-1.35%) ⬇️
...apache/rocketmq/store/ha/GroupTransferService.java 92.30% <0.00%> (-1.29%) ⬇️
... and 13 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@hzh0425 hzh0425 merged commit ddfee4b into apache:develop Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants