Skip to content

Conversation

@ShadowySpirits
Copy link
Member

close #5891

@codecov-commenter
Copy link

codecov-commenter commented Jan 16, 2023

Codecov Report

❌ Patch coverage is 62.76596% with 560 lines in your changes missing coverage. Please review.
✅ Project coverage is 43.28%. Comparing base (9700211) to head (a120102).
⚠️ Report is 1134 commits behind head on develop.

Files with missing lines Patch % Lines
.../apache/rocketmq/tieredstore/TieredDispatcher.java 45.00% 123 Missing and 31 partials ⚠️
...che/rocketmq/tieredstore/TieredMessageFetcher.java 71.18% 69 Missing and 31 partials ⚠️
...tieredstore/metrics/TieredStoreMetricsManager.java 57.86% 83 Missing ⚠️
.../tieredstore/container/TieredContainerManager.java 45.11% 68 Missing and 5 partials ⚠️
...edstore/container/TieredMessageQueueContainer.java 72.72% 47 Missing and 16 partials ⚠️
...pache/rocketmq/tieredstore/TieredMessageStore.java 71.81% 39 Missing and 23 partials ⚠️
...e/rocketmq/tieredstore/common/MessageCacheKey.java 46.15% 4 Missing and 3 partials ⚠️
...dstore/common/SelectMappedBufferResultWrapper.java 68.42% 6 Missing ⚠️
...etmq/tieredstore/common/InflightRequestFuture.java 80.00% 2 Missing and 3 partials ⚠️
...ocketmq/tieredstore/common/InflightRequestKey.java 75.00% 3 Missing and 2 partials ⚠️
... and 2 more
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #5892      +/-   ##
=============================================
+ Coverage      42.71%   43.28%   +0.57%     
- Complexity      8487     8793     +306     
=============================================
  Files           1079     1090      +11     
  Lines          74917    76412    +1495     
  Branches        9796     9981     +185     
=============================================
+ Hits           31999    33078    +1079     
- Misses         38883    39180     +297     
- Partials        4035     4154     +119     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ShadowySpirits ShadowySpirits marked this pull request as ready for review January 17, 2023 02:25
@aaron-ai
Copy link
Member

About the part of calling APIs of the specific storage system, there should be an independent interface class including the method of TieredFileSegment#commit0 and TieredFileSegment#read0. The single responsibility principle is essential.

@ShadowySpirits
Copy link
Member Author

About the part of calling APIs of the specific storage system, there should be an independent interface class including the method of TieredFileSegment#commit0 and TieredFileSegment#read0. The single responsibility principle is essential.

I have moved TieredFileSegment to tieredstore.provider package and make it implement TieredStoreBackendProvider interface.

@ShadowySpirits ShadowySpirits requested review from aaron-ai and lollipopjin and removed request for aaron-ai and lollipopjin January 17, 2023 07:30
Copy link
Contributor

@lollipopjin lollipopjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now.

@lollipopjin lollipopjin merged commit 215b8de into apache:develop Jan 17, 2023
@ShadowySpirits ShadowySpirits deleted the tiered_storage branch January 17, 2023 08:55
drpmma pushed a commit that referenced this pull request Feb 21, 2023
* implement MessageStore interface for tiered store

* fix bazel

* fix unit test

* fix unit test in windows

* fix according to comments

* fix according to comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RIP-57] Implement MessageStore interface for tiered store

4 participants