-
Notifications
You must be signed in to change notification settings - Fork 12k
[Issue #5891] Implement MessageStore interface for tiered store #5892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #5892 +/- ##
=============================================
+ Coverage 42.71% 43.28% +0.57%
- Complexity 8487 8793 +306
=============================================
Files 1079 1090 +11
Lines 74917 76412 +1495
Branches 9796 9981 +185
=============================================
+ Hits 31999 33078 +1079
- Misses 38883 39180 +297
- Partials 4035 4154 +119 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
9acd17d to
8d3e645
Compare
tieredstore/src/main/java/org/apache/rocketmq/store/tiered/TieredDispatcher.java
Outdated
Show resolved
Hide resolved
...re/src/main/java/org/apache/rocketmq/store/tiered/container/TieredMessageQueueContainer.java
Show resolved
Hide resolved
|
About the part of calling APIs of the specific storage system, there should be an independent interface class including the method of |
af73aea to
5da7ccb
Compare
...dstore/src/main/java/org/apache/rocketmq/store/tiered/metrics/TieredStoreMetricsManager.java
Outdated
Show resolved
Hide resolved
I have moved |
lollipopjin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now.
close #5891