Skip to content

Conversation

@lizhimins
Copy link
Member

@lizhimins lizhimins commented Jan 30, 2023

@codecov-commenter
Copy link

Codecov Report

Merging #5951 (c9d3042) into develop (bcaebf1) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             develop    #5951      +/-   ##
=============================================
- Coverage      43.37%   43.35%   -0.02%     
- Complexity      8798     8805       +7     
=============================================
  Files           1090     1090              
  Lines          76435    76435              
  Branches        9987     9987              
=============================================
- Hits           33150    33142       -8     
- Misses         39137    39149      +12     
+ Partials        4148     4144       -4     
Impacted Files Coverage Δ
...a/org/apache/rocketmq/broker/BrokerController.java 43.25% <0.00%> (-3.43%) ⬇️
...he/rocketmq/broker/processor/PopReviveService.java 39.41% <0.00%> (-1.35%) ⬇️
.../apache/rocketmq/store/ha/DefaultHAConnection.java 65.86% <0.00%> (-1.21%) ⬇️
...a/org/apache/rocketmq/store/StoreStatsService.java 33.42% <0.00%> (-1.11%) ⬇️
...ent/impl/consumer/DefaultLitePullConsumerImpl.java 68.28% <0.00%> (-0.63%) ⬇️
.../org/apache/rocketmq/store/ha/DefaultHAClient.java 61.53% <0.00%> (-0.52%) ⬇️
...cketmq/broker/processor/PopBufferMergeService.java 33.41% <0.00%> (-0.24%) ⬇️
...ava/org/apache/rocketmq/filter/util/BitsArray.java 59.82% <0.00%> (ø)
.../org/apache/rocketmq/proxy/config/ProxyConfig.java 44.65% <0.00%> (ø)
...main/java/org/apache/rocketmq/store/CommitLog.java 65.13% <0.00%> (+0.10%) ⬆️
... and 11 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@mxsm mxsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

@lizhimins lizhimins merged commit bb03bf6 into apache:develop Jan 30, 2023
drpmma pushed a commit that referenced this pull request Feb 21, 2023
fix old version plugin bug, link: https://blogs.apache.org/maven/entry/apache-maven-assembly-plugin-version

Co-authored-by: 斜阳 <terrance.lzm@alibaba-inc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants