Skip to content

Conversation

@xdkxlk
Copy link
Contributor

@xdkxlk xdkxlk commented Feb 8, 2023

Make sure set the target branch to develop

What is the purpose of the change

close #6012

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@codecov-commenter
Copy link

Codecov Report

Merging #6013 (f0e02c6) into develop (4ca7e79) will decrease coverage by 0.01%.
The diff coverage is 75.00%.

@@              Coverage Diff              @@
##             develop    #6013      +/-   ##
=============================================
- Coverage      43.40%   43.39%   -0.01%     
+ Complexity      8833     8828       -5     
=============================================
  Files           1090     1090              
  Lines          76628    76628              
  Branches       10008    10007       -1     
=============================================
- Hits           33257    33253       -4     
- Misses         39209    39219      +10     
+ Partials        4162     4156       -6     
Impacted Files Coverage Δ
...cketmq/broker/processor/PopBufferMergeService.java 33.41% <0.00%> (ø)
...a/org/apache/rocketmq/store/pop/PopCheckPoint.java 0.00% <ø> (ø)
...broker/processor/ChangeInvisibleTimeProcessor.java 56.58% <100.00%> (ø)
...rocketmq/broker/processor/PopMessageProcessor.java 36.68% <100.00%> (-0.46%) ⬇️
...he/rocketmq/broker/processor/PopReviveService.java 39.41% <100.00%> (ø)
...rocketmq/client/impl/factory/MQClientInstance.java 47.41% <0.00%> (-1.78%) ⬇️
...cketmq/broker/schedule/ScheduleMessageService.java 56.91% <0.00%> (-1.14%) ⬇️
...he/rocketmq/client/trace/AsyncTraceDispatcher.java 82.21% <0.00%> (-0.97%) ⬇️
...mq/client/impl/producer/DefaultMQProducerImpl.java 46.17% <0.00%> (-0.25%) ⬇️
... and 13 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@xdkxlk xdkxlk merged commit 3ac1977 into apache:develop Feb 9, 2023
@xdkxlk xdkxlk deleted the develop-6012 branch February 9, 2023 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pop consumer with big queue num will case out of bounds problem

5 participants