Skip to content

Selector parse EOF#602

Closed
zhangyanc wants to merge 4 commits intoapache:masterfrom
zhangyanc:selector_parse_eof
Closed

Selector parse EOF#602
zhangyanc wants to merge 4 commits intoapache:masterfrom
zhangyanc:selector_parse_eof

Conversation

@zhangyanc
Copy link

What is the purpose of the change

There are some minor errors in SelectorParser.jj, and it should work like ActiveMQ using javacc plugin

Brief changelog

  • An incorrect import of LRUCache was deleted from SelectorParser.jj
  • Add EOF token to match the end of selector sql, so selector like "a < 10bbbbb" will fail to parse, rather than parse out (a < 10)
  • Changed the way quotes are compared so that there are no compile error with '\u005c' in generated SelectorParser.java
  • add javacc plugin to automatically generate code, so we don't have to manual generate code with javacc command line when each time of .jj updated

Verifying this change

No Java code was modified and all the exist tests passed

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 43.258% when pulling d978b57 on zhangyanc:selector_parse_eof into b32668b on apache:master.

@vongosling vongosling force-pushed the master branch 2 times, most recently from 247e0bf to ce4478a Compare October 12, 2019 06:44
@ShannonDing
Copy link
Member

close due to time too long and wrong to merge to master, welcome to create a new PR to the apache: develop branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants