Skip to content

Conversation

@hardyfish
Copy link
Contributor

Make sure set the target branch to develop

What is the purpose of the change

close #6073

Brief changelog

remove static reference

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@codecov-commenter
Copy link

codecov-commenter commented Feb 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.23%. Comparing base (c8e22a6) to head (05a0e5b).
Report is 824 commits behind head on develop.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #6074      +/-   ##
=============================================
- Coverage      43.33%   43.23%   -0.10%     
- Complexity      8837     8841       +4     
=============================================
  Files           1093     1094       +1     
  Lines          76857    77102     +245     
  Branches       10013    10055      +42     
=============================================
+ Hits           33303    33333      +30     
- Misses         39390    39606     +216     
+ Partials        4164     4163       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RongtongJin RongtongJin merged commit bf33443 into apache:develop Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

remove static reference

4 participants