Skip to content

[ISSUE #608] Update rest of details (polish the example module)#624

Closed
RongtongJin wants to merge 1 commit intoapache:developfrom
RongtongJin:remaining_modification
Closed

[ISSUE #608] Update rest of details (polish the example module)#624
RongtongJin wants to merge 1 commit intoapache:developfrom
RongtongJin:remaining_modification

Conversation

@RongtongJin
Copy link
Contributor

What is the purpose of the change

Fix issue608
Update rest of details (polish the example module)

Brief changelog

  • batch (typo check)
    • SimpleBatchProducer.java
    • SplitBatchProducer.java
  • broadcast
    • BroadcastConsumer.java (renamed from PushConsumer.java, a clearer class name)
  • openmessaging
    • OMSProducer.java (renamed from SimpleProducer.java)
    • OMSPullConsumer.java (renamed from SimplePullConsumer.java)
    • OMSPushConsumer.java (renamed from SimplePushConsumer.java)
  • operation(remove this package, unsuitable)
    • Consumer.java
    • Producer.java
  • quickstart

delete resources/MessageFilterImpl.java

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 43.079% when pulling c7e5866 on RongtongJin:remaining_modification into 385c695 on apache:develop.

Message message = producer.createBytesMessage("OMS_HELLO_TOPIC", "OMS_HELLO_BODY".getBytes(Charset.forName("UTF-8")));
SendResult sendResult = producer.send(message);
//final Void aVoid = result.get(3000L);
// final Void aVoid = result.get(3000L);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this commented out line for?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants