Skip to content

[ISSUE#403] fix some bugs and Optimization code for rocketmq's acl feature.#628

Merged
duhenglucky merged 1 commit intoapache:feature_aclfrom
zongtanghu:feature_acl
Dec 24, 2018
Merged

[ISSUE#403] fix some bugs and Optimization code for rocketmq's acl feature.#628
duhenglucky merged 1 commit intoapache:feature_aclfrom
zongtanghu:feature_acl

Conversation

@zongtanghu
Copy link
Contributor

What is the purpose of the change
Fix some bugs for acl feature.

Brief changelog
(1)add the META-INF/service/org.apache.rocketmq.acl.AccessValidator in broker module.
(2)fix some NPE Exception in rocketmq acl module.
(3)fix some logical Exception and optimize some codes for acl feature.

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@duhenglucky
Copy link
Contributor

LGTM

@duhenglucky duhenglucky merged commit 1dca088 into apache:feature_acl Dec 24, 2018
@ShannonDing ShannonDing added this to the 4.4.0 milestone Jan 16, 2019
renshuaibing-aaron pushed a commit to renshuaibing-aaron/rocketmq that referenced this pull request Apr 13, 2020
[ISSUE#403] Fix some bugs and Optimization code for RocketMQ's ACL feature.
JiaMingLiu93 pushed a commit to JiaMingLiu93/rocketmq that referenced this pull request May 28, 2020
[ISSUE#403] Fix some bugs and Optimization code for RocketMQ's ACL feature.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants