[ISSUE #6290]Optimize LatencyFaultToleranceImpl#updateFaultItem method #6291
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drpmma
reviewed
Mar 9, 2023
| old.setStartTimestamp(System.currentTimeMillis() + notAvailableDuration); | ||
| } | ||
| } else { | ||
| FaultItem old = this.faultItemTable.putIfAbsent(name, new FaultItem(name, currentLatency, System.currentTimeMillis() + notAvailableDuration)); |
Contributor
There was a problem hiding this comment.
Maybe computeIfAbsent is more suitable for reducing extra object creation.
Member
Author
There was a problem hiding this comment.
@drpmma thanks for you suggestion. I will fix it and resubmit later
Codecov Report
@@ Coverage Diff @@
## develop #6291 +/- ##
=============================================
+ Coverage 43.12% 43.15% +0.02%
- Complexity 8847 8856 +9
=============================================
Files 1095 1094 -1
Lines 77279 77247 -32
Branches 10082 10081 -1
=============================================
+ Hits 33324 33333 +9
+ Misses 39782 39745 -37
+ Partials 4173 4169 -4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
This PR is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. If you wish not to mark it as stale, please leave a comment in this PR. |
|
This PR was closed because it has been inactive for 3 days since being marked as stale. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure set the target branch to
developWhat is the purpose of the change
fix #6290
Brief changelog
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice,
it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.[ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyleto make sure basic checks pass. Runmvn clean install -DskipITsto make sure unit-test pass. Runmvn clean test-compile failsafe:integration-testto make sure integration-test pass.