Skip to content

Update SendMessageProcessor.java#660

Closed
shuhan-happy wants to merge 1 commit intoapache:masterfrom
shuhan-happy:master
Closed

Update SendMessageProcessor.java#660
shuhan-happy wants to merge 1 commit intoapache:masterfrom
shuhan-happy:master

Conversation

@shuhan-happy
Copy link
Copy Markdown

change param name (startTimstamp to startTimestamp)

What is the purpose of the change

change wrong param name

Brief changelog

startTimstamp to startTimestamp

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

change param name (startTimestamp to startTimestamp)
@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.05%) to 43.172% when pulling 862730c on fuchun:master into d4d02b5 on apache:master.

@liuruiyiyang
Copy link
Copy Markdown
Contributor

Please merge into develop branch.

@vongosling vongosling force-pushed the master branch 2 times, most recently from 247e0bf to ce4478a Compare October 12, 2019 06:44
@RongtongJin
Copy link
Copy Markdown
Contributor

I think the code is OK, but please merge into the develop branch and submit the corresponding issue. I'll close this PR first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants