[ISSUE #6652] Fix reset offset fail when group is CID_RMQ_SYS_REVIVE_GROUP and enable useServerSideResetOffset #6675
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leizhiyuan
changed the title
…ill fail, we add this to solve this issue
Codecov Report
@@ Coverage Diff @@
## develop #6675 +/- ##
=============================================
- Coverage 43.13% 43.01% -0.13%
- Complexity 9005 9014 +9
=============================================
Files 1107 1109 +2
Lines 78297 78591 +294
Branches 10204 10226 +22
=============================================
+ Hits 33776 33805 +29
- Misses 40302 40553 +251
- Partials 4219 4233 +14
... and 47 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
lizhimins
approved these changes
May 9, 2023
lizhimins
changed the title
lizhimins
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Issue(s) This PR Fixes
Fixes #6652
Brief Description
if REVIVE_TOPIC exists, but biz topic deleted, we can not skip , so we can reset offset , but if we want to reset the offset, now it is impossible, because no consumer online (system group),and no use for this.
How Did You Test This Change?