Skip to content

sendLatencyFaultEnable logical optimization#677

Closed
alaric27 wants to merge 1 commit intoapache:masterfrom
alaric27:bugfix
Closed

sendLatencyFaultEnable logical optimization#677
alaric27 wants to merge 1 commit intoapache:masterfrom
alaric27:bugfix

Conversation

@alaric27
Copy link

What is the purpose of the change

selectOneMessageQueue logical optimization
I find this logic useless. When find available MessageQueue can just return

Brief changelog

delete code if (null == lastBrokerName || mq.getBrokerName().equals(lastBrokerName))

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.04%) to 43.143% when pulling eb1af61 on alaric27:bugfix into f8a67ad on apache:master.

@alaric27 alaric27 closed this Jan 14, 2019
@alaric27 alaric27 deleted the bugfix branch January 14, 2019 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants