Skip to content

Conversation

@zekai-li
Copy link
Contributor

Which Issue(s) This PR Fixes

Fixes #6808

Brief Description

Fix the following three as
1,TraceBean: private static final String LOCAL_ADDRESS = UtilAll.ipToIPv4Str(UtilAll.getIP()); getIP mayby ipv6
2,NetworkUtil:if (ip.startsWith("127.0") || ip.startsWith("192.168") || ip.startsWith("0."));Check whether Intranet errors exist
3,NetworkUtil, MixAll, UtilAll three code repeats, refactoring NetworkUtil related code as a tool outlet for network unified logic

How Did You Test This Change?

networkutiltest was set up for code testing

@zekai-li zekai-li force-pushed the develop branch 2 times, most recently from 2902564 to 60dab2d Compare May 25, 2023 09:03
@zekai-li
Copy link
Contributor Author

@HScarb Please take a look and resubmit to check the build

@zekai-li
Copy link
Contributor Author

zekai-li commented Jun 8, 2023

@RongtongJin Please take a look and resubmit to check the build

@zekai-li
Copy link
Contributor Author

zekai-li commented Sep 5, 2023

@RongtongJin Please check it.

2 similar comments
@zekai-li
Copy link
Contributor Author

@RongtongJin Please check it.

@zekai-li
Copy link
Contributor Author

zekai-li commented Oct 7, 2023

@RongtongJin Please check it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Multiple localaddress usage errors, and networkutil code duplication with logical errors

1 participant