Skip to content

Fix NettyRemotingClient.isChannelWritable#695

Closed
zhouhailin wants to merge 4 commits intoapache:masterfrom
zhouhailin:master
Closed

Fix NettyRemotingClient.isChannelWritable#695
zhouhailin wants to merge 4 commits intoapache:masterfrom
zhouhailin:master

Conversation

@zhouhailin
Copy link

remote addr isChannelWritable, if cw == null or cw.isOK() should be false.

What is the purpose of the change

fix if addr is not in channelTables.

Brief changelog

ok

Verifying this change

ok

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

remote addr isChannelWritable, if cw == null or cw.isOK() should be false.
@coveralls
Copy link

coveralls commented Jan 16, 2019

Coverage Status

Coverage decreased (-0.02%) to 43.163% when pulling 1d0bbb8 on zhouhailin:master into f8a67ad on apache:master.

@zhouhailin zhouhailin changed the title Update NettyRemotingClient.java Fix NettyRemotingClient.isChannelWritable Jan 17, 2019
使用char性能更好
特殊的情况下,出现线程异常
@vongosling vongosling force-pushed the master branch 2 times, most recently from 247e0bf to ce4478a Compare October 12, 2019 06:44
@RongtongJin
Copy link
Contributor

IMO, it is indeed a bug, but please merge into the develop branch and submit the corresponding issue. I'll close this PR first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants