Skip to content

[RIP-10] Add test cases for CommitLog.handleHA#802

Closed
a51764579 wants to merge 15 commits intoapache:developfrom
a51764579:master
Closed

[RIP-10] Add test cases for CommitLog.handleHA#802
a51764579 wants to merge 15 commits intoapache:developfrom
a51764579:master

Conversation

@a51764579
Copy link
Copy Markdown
Contributor

What is the purpose of the change

Add test cases for CommitLog.handleHA.

Brief changelog

test for CommitLog.handleHA.

Verifying this change

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@a51764579 a51764579 changed the title Add test cases for CommitLog.handleHA [RIP-10] Add test cases for CommitLog.handleHA Feb 18, 2019
@ShannonDing ShannonDing added this to the 4.4.1 milestone Feb 18, 2019
@hdchen
Copy link
Copy Markdown
Contributor

hdchen commented Feb 18, 2019

LGTM

@coveralls
Copy link
Copy Markdown

coveralls commented Feb 18, 2019

Coverage Status

Coverage increased (+1.2%) to 46.043% when pulling 9fa2d5b on a51764579:master into 6a573a7 on apache:develop.

@ShannonDing
Copy link
Copy Markdown
Member

Could you please remove the unnecessary commit logs?

@a51764579
Copy link
Copy Markdown
Contributor Author

Could you please remove the unnecessary commit logs?

@a51764579 a51764579 closed this Feb 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants