Skip to content

[RIP-9]Add the Configuration_System in RocketMQ#803

Closed
liuyingjie-asir wants to merge 1 commit intoapache:masterfrom
liuyingjie-asir:master
Closed

[RIP-9]Add the Configuration_System in RocketMQ#803
liuyingjie-asir wants to merge 1 commit intoapache:masterfrom
liuyingjie-asir:master

Conversation

@liuyingjie-asir
Copy link
Contributor

What is the purpose of the change

support other producer

Brief changelog

Add the Configuration_System in RocketMQ

Verifying this change

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 44.83% when pulling 7b34c94 on lyjLovezxn:master into 46ac065 on apache:master.

@ShannonDing
Copy link
Member

Please commit the PR to the develop branch. Could you please close this PR and create a new one?

@ShannonDing
Copy link
Member

@lyjLovezxn

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants