[RIP-11]MQTT:completing pub and sub logic of qos=0 messages(single node only )#842
[RIP-11]MQTT:completing pub and sub logic of qos=0 messages(single node only )#842duhenglucky merged 3 commits intoapache:snodefrom
Conversation
duhenglucky
left a comment
There was a problem hiding this comment.
Very glad to see that have already completed the pub/sub logic in qos0 level, but there are still exists some issues about this PR, and we also need to add more unit test in this module, and in the later, IMO, we should separate the mqtt related codes to a single module.
|
|
||
| private int snodePushMessageThreadPoolQueueCapacity = 10000; | ||
|
|
||
| private int snodePushMqttMessageMinPoolSize = 10; |
There was a problem hiding this comment.
Maybe we can define a mqttConfig class to manage these configs related to MQTT.
| .registerProcessor(RequestCode.UPDATE_CONSUMER_OFFSET, consumerManageProcessor, | ||
| private void registerProcessor() { | ||
| if(snodeServer != null) { | ||
| this.snodeServer.registerProcessor(RequestCode.SEND_MESSAGE_V2, sendMessageProcessor, |
There was a problem hiding this comment.
Please don't change the code format if we have no change about this, it will lead us difficult to review these codes later
|
|
||
| private transient byte[] body; | ||
|
|
||
| private Object payload; |
There was a problem hiding this comment.
why do you want to add a new property here? and it would be nice if we can use byte[] body instead.
|
Please rebase and resolve the conflict codes in the Conflicting file list. |
14a2f25 to
6f38100
Compare
6f38100 to
c36f09a
Compare
What is the purpose of the change
finish single-node version of publish and subscribe logic of qos=0 messages
Brief changelog
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice,
it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.[ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyleto make sure basic checks pass. Runmvn clean install -DskipITsto make sure unit-test pass. Runmvn clean test-compile failsafe:integration-testto make sure integration-test pass.