Skip to content

[RIP-11]MQTT:completing pub and sub logic of qos=0 messages(single node only )#842

Merged
duhenglucky merged 3 commits intoapache:snodefrom
xiangwangcheng:snode
Mar 7, 2019
Merged

[RIP-11]MQTT:completing pub and sub logic of qos=0 messages(single node only )#842
duhenglucky merged 3 commits intoapache:snodefrom
xiangwangcheng:snode

Conversation

@xiangwangcheng
Copy link

What is the purpose of the change

finish single-node version of publish and subscribe logic of qos=0 messages

Brief changelog

  1. completing logic of publishing and subscribing, unsubscribing
  2. polish the logic of encode/decode between MqttMessage and RemotingCommand
  3. add some NPE inSnodeController.java

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • [√] Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • [√] Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • [√] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • [√] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • [√] Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

Copy link
Contributor

@duhenglucky duhenglucky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very glad to see that have already completed the pub/sub logic in qos0 level, but there are still exists some issues about this PR, and we also need to add more unit test in this module, and in the later, IMO, we should separate the mqtt related codes to a single module.


private int snodePushMessageThreadPoolQueueCapacity = 10000;

private int snodePushMqttMessageMinPoolSize = 10;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can define a mqttConfig class to manage these configs related to MQTT.

.registerProcessor(RequestCode.UPDATE_CONSUMER_OFFSET, consumerManageProcessor,
private void registerProcessor() {
if(snodeServer != null) {
this.snodeServer.registerProcessor(RequestCode.SEND_MESSAGE_V2, sendMessageProcessor,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't change the code format if we have no change about this, it will lead us difficult to review these codes later


private transient byte[] body;

private Object payload;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do you want to add a new property here? and it would be nice if we can use byte[] body instead.

@zongtanghu
Copy link
Contributor

Please rebase and resolve the conflict codes in the Conflicting file list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants