Skip to content

[RIP-10] Add test case for SubscriptionData#863

Merged
ShannonDing merged 1 commit intoapache:developfrom
CodingSinger:unit50-develop
May 14, 2019
Merged

[RIP-10] Add test case for SubscriptionData#863
ShannonDing merged 1 commit intoapache:developfrom
CodingSinger:unit50-develop

Conversation

@CodingSinger
Copy link
Member

What is the purpose of the change

add test case for SubscriptionData

Brief changelog

add test case for SubscriptionData

Verifying this change

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@CodingSinger CodingSinger changed the title Add test case for SubscriptionData [RIP-10] Add test case for SubscriptionData Feb 22, 2019
@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 47.784% when pulling 9cff7bb on CodingSinger:unit50-develop into 580037f on apache:develop.

@hdchen
Copy link
Contributor

hdchen commented Mar 3, 2019

LGTM

@ShannonDing ShannonDing added this to the 4.5.1 milestone May 14, 2019
@ShannonDing ShannonDing merged commit 1181314 into apache:develop May 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants