Skip to content

[ISSUE #9050] Fix repeat response code#9051

Open
bxfjb wants to merge 3 commits intoapache:developfrom
bxfjb:fix-repeat-response-code
Open

[ISSUE #9050] Fix repeat response code#9051
bxfjb wants to merge 3 commits intoapache:developfrom
bxfjb:fix-repeat-response-code

Conversation

@bxfjb
Copy link
Contributor

@bxfjb bxfjb commented Dec 12, 2024

Which Issue(s) This PR Fixes

Fixes #9050

Brief Description

How Did You Test This Change?

@humkum
Copy link
Contributor

humkum commented Dec 16, 2024

Maybe you should modify the duplicate response code to completely solve this problem

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.85%. Comparing base (9aa081b) to head (b75f678).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #9051      +/-   ##
=============================================
- Coverage      48.01%   47.85%   -0.16%     
+ Complexity     11903    11863      -40     
=============================================
  Files           1312     1312              
  Lines          91735    91735              
  Branches       11751    11751              
=============================================
- Hits           44042    43900     -142     
- Misses         42291    42415     +124     
- Partials        5402     5420      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@lizhimins lizhimins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might break protocol compatibility, for example, by causing the client to disconnect. Please correct me if my understanding is incorrect.

@bxfjb
Copy link
Contributor Author

bxfjb commented Feb 12, 2025

This might break protocol compatibility, for example, by causing the client to disconnect. Please correct me if my understanding is incorrect.

The pr means to solve the repeated response code 209~211, is there any other solution?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Repeat response code

4 participants