Skip to content

Revert "[ISSUE #9176] Fix pop message header missing fields when enable ACL 2.0"#9211

Merged
lollipopjin merged 1 commit intodevelopfrom
revert-9179-fix_pop_decode
Feb 28, 2025
Merged

Revert "[ISSUE #9176] Fix pop message header missing fields when enable ACL 2.0"#9211
lollipopjin merged 1 commit intodevelopfrom
revert-9179-fix_pop_decode

Conversation

@lizhimins
Copy link
Member

When there is a time difference between the client and the server, it can cause issues with suspending long-polling POP requests.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.08%. Comparing base (19f799d) to head (c909084).

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #9211      +/-   ##
=============================================
- Coverage      48.10%   48.08%   -0.03%     
+ Complexity     12106    12095      -11     
=============================================
  Files           1321     1321              
  Lines          93081    93080       -1     
  Branches       11933    11933              
=============================================
- Hits           44779    44754      -25     
- Misses         42773    42788      +15     
- Partials        5529     5538       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@lollipopjin lollipopjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lollipopjin lollipopjin merged commit 5936695 into develop Feb 28, 2025
10 of 11 checks passed
@lizhimins lizhimins deleted the revert-9179-fix_pop_decode branch March 8, 2025 06:15
3424672656 pushed a commit to 3424672656/rocketmq that referenced this pull request May 12, 2025
RongtongJin pushed a commit that referenced this pull request Jul 19, 2025
ChineseTony pushed a commit to ChineseTony/rocketmq that referenced this pull request Aug 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants