Skip to content

[RIP-40] Add test case for LockBatchResponseBody#926

Closed
icersummer wants to merge 5 commits intoapache:developfrom
icersummer:develop
Closed

[RIP-40] Add test case for LockBatchResponseBody#926
icersummer wants to merge 5 commits intoapache:developfrom
icersummer:develop

Conversation

@icersummer
Copy link
Copy Markdown

What is the purpose of the change

Add test case (LockBatchResponseBodyTest.java) for org.apache.rocketmq.common.protocol.body.LockBatchResponseBody.java

Brief changelog

Add test case (LockBatchResponseBodyTest.java) for org.apache.rocketmq.common.protocol.body.LockBatchResponseBody.java

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.07%) to 47.997% when pulling c1c9904 on icersummer:develop into 42ddf3d on apache:develop.

@icersummer icersummer changed the title Develop [RIP-40] Add test case for LockBatchResponseBody Apr 4, 2019
@RongtongJin
Copy link
Copy Markdown
Contributor

Besides test, there are other commit records. Could you please handle them?

@RongtongJin RongtongJin self-assigned this Mar 27, 2020
@RongtongJin
Copy link
Copy Markdown
Contributor

I'll close this PR first. Please feel free to reopen it if you have any other questions.

@RongtongJin RongtongJin closed this Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants