Skip to content

[RIP-10] Add test cases for QueryMsgByUniqueKeySubCommand#945

Merged
ShannonDing merged 5 commits intoapache:developfrom
codefans:develop
May 14, 2019
Merged

[RIP-10] Add test cases for QueryMsgByUniqueKeySubCommand#945
ShannonDing merged 5 commits intoapache:developfrom
codefans:develop

Conversation

@codefans
Copy link
Contributor

What is the purpose of the change

   Add test cases for QueryMsgByUniqueKeySubCommand

Brief changelog

   Add QueryMsgByUniqueKeySubCommandTest.java

Verifying this change

   run QueryMsgByUniqueKeySubCommandTest.java

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@Test
public void testExecute() throws SubCommandException {

System.setProperty("rocketmq.namesrv.addr", "127.0.0.1:9876");

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test case shouldn't depend on specific values like "127.0.0.1:9876"(namesrv addr) and "myTopicTest"(topic name). That makes the test case fail on others' PC.

@coveralls
Copy link

coveralls commented Mar 5, 2019

Coverage Status

Coverage decreased (-0.2%) to 48.808% when pulling fd19e35 on codefans:develop into 4f8d96c on apache:develop.

@hdchen
Copy link
Contributor

hdchen commented Mar 7, 2019

LGTM

@zongtanghu
Copy link
Contributor

This pr add the test case for QueryMsgByUniqueKeySubCommand,but CI code coverage is down.Can you find the reason by looking at the CI code coverate report?

@zongtanghu zongtanghu self-requested a review March 7, 2019 15:05
@zongtanghu zongtanghu added this to the 4.5.0 milestone Mar 7, 2019
@ShannonDing ShannonDing modified the milestones: 4.5.0, 4.6.0 Apr 10, 2019
@ShannonDing ShannonDing modified the milestones: 4.6.0, 4.5.1 May 14, 2019
@ShannonDing ShannonDing merged commit 26878e9 into apache:develop May 14, 2019
JiaMingLiu93 pushed a commit to JiaMingLiu93/rocketmq that referenced this pull request May 28, 2020
pulllock pushed a commit to pulllock/rocketmq that referenced this pull request Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants