[RIP-10] Add test cases for QueryMsgByUniqueKeySubCommand#945
Merged
ShannonDing merged 5 commits intoapache:developfrom May 14, 2019
Merged
[RIP-10] Add test cases for QueryMsgByUniqueKeySubCommand#945ShannonDing merged 5 commits intoapache:developfrom
ShannonDing merged 5 commits intoapache:developfrom
Conversation
| @Test | ||
| public void testExecute() throws SubCommandException { | ||
|
|
||
| System.setProperty("rocketmq.namesrv.addr", "127.0.0.1:9876"); |
There was a problem hiding this comment.
The test case shouldn't depend on specific values like "127.0.0.1:9876"(namesrv addr) and "myTopicTest"(topic name). That makes the test case fail on others' PC.
Contributor
|
LGTM |
Contributor
|
This pr add the test case for QueryMsgByUniqueKeySubCommand,but CI code coverage is down.Can you find the reason by looking at the CI code coverate report? |
JiaMingLiu93
pushed a commit
to JiaMingLiu93/rocketmq
that referenced
this pull request
May 28, 2020
pulllock
pushed a commit
to pulllock/rocketmq
that referenced
this pull request
Oct 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Brief changelog
Verifying this change
Follow this checklist to help us incorporate your contribution quickly and easily. Notice,
it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.[ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyleto make sure basic checks pass. Runmvn clean install -DskipITsto make sure unit-test pass. Runmvn clean test-compile failsafe:integration-testto make sure integration-test pass.