Skip to content

[RIP-10]optimized DefaultMessageStoreTest: invoke flush consume queue instead of sleeping few seconds#966

Closed
wnow20 wants to merge 2 commits intoapache:developfrom
wnow20:wnow20_store_fix_sleep_tricks
Closed

[RIP-10]optimized DefaultMessageStoreTest: invoke flush consume queue instead of sleeping few seconds#966
wnow20 wants to merge 2 commits intoapache:developfrom
wnow20:wnow20_store_fix_sleep_tricks

Conversation

@wnow20
Copy link
Contributor

@wnow20 wnow20 commented Mar 2, 2019

What is the purpose of the change

optimized DefaultMessageStoreTest: invoke flush consume queue instead of sleeping few seconds

Brief changelog

  1. call StoreTestUtil.flushConsumeQueue instead of Thread.sleep.
  2. modify method names of test cases.
  3. arrange private method that appending to the end of the file.
  4. divide one testRecover into three smaller cases.

Verifying this change

All tests include DefaultMessageStoreTest run pass.

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 49.057% when pulling d635f9f on wnow20:wnow20_store_fix_sleep_tricks into bbb723f on apache:develop.

@wnow20 wnow20 closed this Mar 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants