fix controller mode scanControllerAddress #9845
Merged
+23
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RongtongJin
approved these changes
Nov 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief Description
增强代码健壮性
How Did You Test This Change?
部署：
rocketmq 5.3.0部署controller模式
一主三从
故障测试：
对其中两个broker做网络延迟故障，网络延迟在1分钟以上。故障恢复发现始终有一个broker不能加入到SyncStateSet里
代码改造后测试：
ReplicasManager的scanControllerAddress线程，在有网络延迟的情况相下确实有可能挂掉，影响AvailableControllerAddress的维护导致AvailableControllerAddress并不包含所有的controller节点，进而影响broker上报心跳到AvailableControllerAddress下的所有controller节点