Skip to content

fix controller mode scanControllerAddress #9845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 12, 2025
Merged

fix controller mode scanControllerAddress #9845

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0a5ae08
Enhancing code robustness
LittleBoy18 Nov 11, 2025
2a1ef10
fix Checkstyle
LittleBoy18 Nov 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 23 additions & 19 deletions broker/src/main/java/org/apache/rocketmq/broker/controller/ReplicasManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -775,29 +775,33 @@ private void stopCheckSyncStateSet() {
}

private void scanAvailableControllerAddresses() {
if (controllerAddresses == null) {
LOGGER.warn("scanAvailableControllerAddresses addresses of controller is null!");
return;
}
try {
if (controllerAddresses == null) {
LOGGER.warn("scanAvailableControllerAddresses addresses of controller is null!");
return;
}

for (String address : availableControllerAddresses.keySet()) {
if (!controllerAddresses.contains(address)) {
LOGGER.warn("scanAvailableControllerAddresses remove invalid address {}", address);
availableControllerAddresses.remove(address);
for (String address : availableControllerAddresses.keySet()) {
if (!controllerAddresses.contains(address)) {
LOGGER.warn("scanAvailableControllerAddresses remove invalid address {}", address);
availableControllerAddresses.remove(address);
}
}
}

for (String address : controllerAddresses) {
scanExecutor.submit(() -> {
if (brokerOuterAPI.checkAddressReachable(address)) {
availableControllerAddresses.putIfAbsent(address, true);
} else {
Boolean value = availableControllerAddresses.remove(address);
if (value != null) {
LOGGER.warn("scanAvailableControllerAddresses remove unconnected address {}", address);
for (String address : controllerAddresses) {
scanExecutor.submit(() -> {
if (brokerOuterAPI.checkAddressReachable(address)) {
availableControllerAddresses.putIfAbsent(address, true);
} else {
Boolean value = availableControllerAddresses.remove(address);
if (value != null) {
LOGGER.warn("scanAvailableControllerAddresses remove unconnected address {}", address);
}
}
}
});
});
}
} catch (final Throwable t) {
LOGGER.error("scanAvailableControllerAddresses unexpected exception", t);
}
}

Expand Down
Loading