ListEvent.as and SliderEvent.as Files Added #138
Conversation
ListEvent file added to the branch
alinakazi
changed the title
Update mx-royale-manifest.xml for ListEvent and SliderEvent
aharui
left a comment
aharui
left a comment
There was a problem hiding this comment.
Looks pretty good, but Events and some other classes should be added to the SWC via MXRoyaleClasses.as instead of mx-royale-manifest.xml. The manifest is for components that you use in MXML as tags. I think some IDEs offer code completion based on manifests. ListEvent should not be offered as a possible MXML tag. ListEvent will be offered when writing AS code either way.
So for this pull request, mx-royale-manifest.xml should not have any modifications. MXRoyaleClasses.as should instead.
Updating MXRoyaleClasses.as for ListEvent and SliderEvent in mxRoyaleAQ Branch
Deletion of rows for SliderEvent and ListEvent
|
In the future, if you get public var warnings, consider whether the warning should be suppressed via @royalesuppresspublicvarwarning or the public var should become a getter/setter. It will depend on whether the class is used in handling server or other external data. I pushed changes to these classes as an example. |
3 participants
Created ListEvent.as file added to "https://github.com/alinakazi/royale-asjs/tree/mxRoyaleAQ"